| Message ID | 20201030004046.2191790-9-kuhn.chenqun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | silence the compiler warnings | expand |
On 10/30/20 1:40 AM, Chen Qun wrote: > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > target/ppc/mmu_helper.c: In function ‘dump_mmu’: > target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through [-Wimplicit-fallthrough=] > 1351 | if (ppc64_v3_radix(env_archcpu(env))) { > | ^ > target/ppc/mmu_helper.c:1358:5: note: here > 1358 | default: > | ^~~~~~~ > > Use "qemu_log_mask(LOG_UNIMP**)" instead of the TODO comment. > And add the break statement to fix it. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > v1->v2: replace the TODO by a LOG_UNIMP call and add break statement(Base on Philippe's comments) > > Cc: Thomas Huth <thuth@redhat.com> > Cc: David Gibson <david@gibson.dropbear.id.au> > Cc: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > target/ppc/mmu_helper.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c > index 8972714775..12723362b7 100644 > --- a/target/ppc/mmu_helper.c > +++ b/target/ppc/mmu_helper.c > @@ -1349,11 +1349,12 @@ void dump_mmu(CPUPPCState *env) > break; > case POWERPC_MMU_3_00: > if (ppc64_v3_radix(env_archcpu(env))) { > - /* TODO - Unsupported */ > + qemu_log_mask(LOG_UNIMP, "%s: the PPC64 MMU unsupported\n", > + __func__); > } else { > dump_slb(env_archcpu(env)); > - break; > } > + break; > #endif > default: > qemu_log_mask(LOG_UNIMP, "%s: unimplemented\n", __func__); > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On 30/10/2020 01.40, Chen Qun wrote: > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > target/ppc/mmu_helper.c: In function ‘dump_mmu’: > target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through [-Wimplicit-fallthrough=] > 1351 | if (ppc64_v3_radix(env_archcpu(env))) { > | ^ > target/ppc/mmu_helper.c:1358:5: note: here > 1358 | default: > | ^~~~~~~ > > Use "qemu_log_mask(LOG_UNIMP**)" instead of the TODO comment. > And add the break statement to fix it. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > v1->v2: replace the TODO by a LOG_UNIMP call and add break statement(Base on Philippe's comments) > > Cc: Thomas Huth <thuth@redhat.com> > Cc: David Gibson <david@gibson.dropbear.id.au> > Cc: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > target/ppc/mmu_helper.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c > index 8972714775..12723362b7 100644 > --- a/target/ppc/mmu_helper.c > +++ b/target/ppc/mmu_helper.c > @@ -1349,11 +1349,12 @@ void dump_mmu(CPUPPCState *env) > break; > case POWERPC_MMU_3_00: > if (ppc64_v3_radix(env_archcpu(env))) { > - /* TODO - Unsupported */ > + qemu_log_mask(LOG_UNIMP, "%s: the PPC64 MMU unsupported\n", Maybe add a "is" between "MMU" and "unsupported"? > + __func__); > } else { > dump_slb(env_archcpu(env)); > - break; > } > + break; > #endif > default: > qemu_log_mask(LOG_UNIMP, "%s: unimplemented\n", __func__); > Reviewed-by: Thomas Huth <thuth@redhat.com>
On Fri, Oct 30, 2020 at 08:40:46AM +0800, Chen Qun wrote: > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > target/ppc/mmu_helper.c: In function ‘dump_mmu’: > target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through [-Wimplicit-fallthrough=] > 1351 | if (ppc64_v3_radix(env_archcpu(env))) { > | ^ > target/ppc/mmu_helper.c:1358:5: note: here > 1358 | default: > | ^~~~~~~ > > Use "qemu_log_mask(LOG_UNIMP**)" instead of the TODO comment. > And add the break statement to fix it. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> > --- > v1->v2: replace the TODO by a LOG_UNIMP call and add break statement(Base on Philippe's comments) > > Cc: Thomas Huth <thuth@redhat.com> > Cc: David Gibson <david@gibson.dropbear.id.au> > Cc: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > target/ppc/mmu_helper.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c > index 8972714775..12723362b7 100644 > --- a/target/ppc/mmu_helper.c > +++ b/target/ppc/mmu_helper.c > @@ -1349,11 +1349,12 @@ void dump_mmu(CPUPPCState *env) > break; > case POWERPC_MMU_3_00: > if (ppc64_v3_radix(env_archcpu(env))) { > - /* TODO - Unsupported */ > + qemu_log_mask(LOG_UNIMP, "%s: the PPC64 MMU unsupported\n", > + __func__); > } else { > dump_slb(env_archcpu(env)); > - break; > } > + break; > #endif > default: > qemu_log_mask(LOG_UNIMP, "%s: unimplemented\n", __func__);
diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index 8972714775..12723362b7 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -1349,11 +1349,12 @@ void dump_mmu(CPUPPCState *env) break; case POWERPC_MMU_3_00: if (ppc64_v3_radix(env_archcpu(env))) { - /* TODO - Unsupported */ + qemu_log_mask(LOG_UNIMP, "%s: the PPC64 MMU unsupported\n", + __func__); } else { dump_slb(env_archcpu(env)); - break; } + break; #endif default: qemu_log_mask(LOG_UNIMP, "%s: unimplemented\n", __func__);
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: target/ppc/mmu_helper.c: In function ‘dump_mmu’: target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through [-Wimplicit-fallthrough=] 1351 | if (ppc64_v3_radix(env_archcpu(env))) { | ^ target/ppc/mmu_helper.c:1358:5: note: here 1358 | default: | ^~~~~~~ Use "qemu_log_mask(LOG_UNIMP**)" instead of the TODO comment. And add the break statement to fix it. Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> --- v1->v2: replace the TODO by a LOG_UNIMP call and add break statement(Base on Philippe's comments) Cc: Thomas Huth <thuth@redhat.com> Cc: David Gibson <david@gibson.dropbear.id.au> Cc: Philippe Mathieu-Daudé <philmd@redhat.com> --- target/ppc/mmu_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)