| Message ID | 20201030145427.3497990-1-amadeuszx.slawinski@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: topology: Change to resource managed memory | expand |
On 10/30/2020 3:54 PM, Amadeusz Sławiński wrote: > Almost all other allocations in ASoC API are resource managed, the only > exception is soc-topology.c. > > This patchset clean ups few unnecessary functions in preparation for > change and then changes to devm_ functions for allocation. > > Amadeusz Sławiński (6): > ASoC: topology: Remove unused functions from topology API > ASoC: topology: Remove multistep topology loading > ASoC: topology: Unify all device references > ASoC: topology: Change allocations to resource managed > ASoC: topology: Remove empty functions > ASoC: topology: Simplify remove_widget function > > include/sound/soc-topology.h | 13 +- > sound/soc/intel/skylake/skl-topology.c | 9 +- > sound/soc/soc-topology.c | 302 +++++-------------------- > sound/soc/sof/pcm.c | 2 +- > sound/soc/sof/topology.c | 4 +- > 5 files changed, 57 insertions(+), 273 deletions(-) > Eh... and of course I've messed up something, there shouldn't be v3 in the topic of cover letter ;) I can resend if you want?
On 2020-10-30 3:54 PM, Amadeusz Sławiński wrote: > Almost all other allocations in ASoC API are resource managed, the only > exception is soc-topology.c. > > This patchset clean ups few unnecessary functions in preparation for > change and then changes to devm_ functions for allocation. > These address some of the long standing issues of resource allocation for topology, thanks for your work. Nitpick: *the 0/7* looks weird given that only 6 patches are actually part of the series. For the series: Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> Thanks, Czarek > Amadeusz Sławiński (6): > ASoC: topology: Remove unused functions from topology API > ASoC: topology: Remove multistep topology loading > ASoC: topology: Unify all device references > ASoC: topology: Change allocations to resource managed > ASoC: topology: Remove empty functions > ASoC: topology: Simplify remove_widget function > > include/sound/soc-topology.h | 13 +- > sound/soc/intel/skylake/skl-topology.c | 9 +- > sound/soc/soc-topology.c | 302 +++++-------------------- > sound/soc/sof/pcm.c | 2 +- > sound/soc/sof/topology.c | 4 +- > 5 files changed, 57 insertions(+), 273 deletions(-) >
On 10/30/2020 3:23 PM, Rojewski, Cezary wrote: > On 2020-10-30 3:54 PM, Amadeusz Sławiński wrote: >> Almost all other allocations in ASoC API are resource managed, the only >> exception is soc-topology.c. >> >> This patchset clean ups few unnecessary functions in preparation for >> change and then changes to devm_ functions for allocation. >> > > These address some of the long standing issues of resource allocation > for topology, thanks for your work. > Nitpick: > *the 0/7* looks weird given that only 6 patches are actually part of the > series. Yes that was a copy&paste mistake, similarly to already mentioned v3. There is only 6 patches. It is a problem caused by manually filling cover letter and copying title from old cover letter to new one. I did some reading, and apparently if one operates on branches to prepare patch sets, they can do something like: $ git branch --edit-description $ git format-patch -6 --cover-letter --cover-from-description=subject And git will automatically populate cover letter with text from branch description. I will try to remember to try it when sending another series. Hopefully this will allow me to avoid copy&paste mistakes, as filling cover letter title and description will be automated ;) Mark, do let me know if you want me to resend. > > For the series: > > Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com> > > Thanks, > Czarek > >> Amadeusz Sławiński (6): >> ASoC: topology: Remove unused functions from topology API >> ASoC: topology: Remove multistep topology loading >> ASoC: topology: Unify all device references >> ASoC: topology: Change allocations to resource managed >> ASoC: topology: Remove empty functions >> ASoC: topology: Simplify remove_widget function >> >> include/sound/soc-topology.h | 13 +- >> sound/soc/intel/skylake/skl-topology.c | 9 +- >> sound/soc/soc-topology.c | 302 +++++-------------------- >> sound/soc/sof/pcm.c | 2 +- >> sound/soc/sof/topology.c | 4 +- >> 5 files changed, 57 insertions(+), 273 deletions(-) >>
On Fri, 30 Oct 2020 10:54:21 -0400, Amadeusz Sławiński wrote: > Almost all other allocations in ASoC API are resource managed, the only > exception is soc-topology.c. > > This patchset clean ups few unnecessary functions in preparation for > change and then changes to devm_ functions for allocation. > > Amadeusz Sławiński (6): > ASoC: topology: Remove unused functions from topology API > ASoC: topology: Remove multistep topology loading > ASoC: topology: Unify all device references > ASoC: topology: Change allocations to resource managed > ASoC: topology: Remove empty functions > ASoC: topology: Simplify remove_widget function > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/6] ASoC: topology: Remove unused functions from topology API commit: 841fb1096713bdd85cb2484557623136e10041d2 [2/6] ASoC: topology: Remove multistep topology loading commit: a5b8f71c5477f4327c66a085d9714fe298510819 [3/6] ASoC: topology: Unify all device references commit: e59db12b8df3ab07dcfe3540ecdf782d4272f263 [4/6] ASoC: topology: Change allocations to resource managed commit: ff922622443767b27232eb01bae1d9a8d42df073 [5/6] ASoC: topology: Remove empty functions commit: 033df362ea3635179d1defed2230be69ed632c05 [6/6] ASoC: topology: Simplify remove_widget function commit: 8d456654839cd4fd10225ffa9c70c64784615f95 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark