diff mbox series

arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet

Message ID 20201101072609.1681891-1-jernej.skrabec@siol.net (mailing list archive)
State New, archived
Headers show
Series arm64: dts: allwinner: h6: orangepi-one-plus: Fix ethernet | expand

Commit Message

Jernej Škrabec Nov. 1, 2020, 7:26 a.m. UTC 
RX/TX delay on OrangePi One Plus board is set on PHY. Reflect that in
ethernet node.

Fixes: 7ee32a17e0d6 ("arm64: dts: allwinner: h6: orangepi-one-plus: Enable ethernet")
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
 arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Code Kipper Nov. 1, 2020, 9:21 a.m. UTC | #1 
On Sun, 1 Nov 2020 at 08:20, Jernej Skrabec <jernej.skrabec@siol.net> wrote:
>
> RX/TX delay on OrangePi One Plus board is set on PHY. Reflect that in
> ethernet node.
>
> Fixes: 7ee32a17e0d6 ("arm64: dts: allwinner: h6: orangepi-one-plus: Enable ethernet")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Hi Jernej,
Tested-by: Marcus Cooper <codekipper@gmail.com>
BR,
CK
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
> index fceb298bfd53..29a081e72a9b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
> @@ -27,7 +27,7 @@ reg_gmac_3v3: gmac-3v3 {
>  &emac {
>         pinctrl-names = "default";
>         pinctrl-0 = <&ext_rgmii_pins>;
> -       phy-mode = "rgmii";
> +       phy-mode = "rgmii-id";
>         phy-handle = <&ext_rgmii_phy>;
>         phy-supply = <&reg_gmac_3v3>;
>         allwinner,rx-delay-ps = <200>;
> --
> 2.29.2
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20201101072609.1681891-1-jernej.skrabec%40siol.net.
Maxime Ripard Nov. 2, 2020, 9:25 a.m. UTC | #2 
On Sun, Nov 01, 2020 at 08:26:09AM +0100, Jernej Skrabec wrote:
> RX/TX delay on OrangePi One Plus board is set on PHY. Reflect that in
> ethernet node.
> 
> Fixes: 7ee32a17e0d6 ("arm64: dts: allwinner: h6: orangepi-one-plus: Enable ethernet")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

Applied. It's not clear yet whether it's the best way forward (the PR
got rejected), so it might need some extra work in the future.

Maxime
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
index fceb298bfd53..29a081e72a9b 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
@@ -27,7 +27,7 @@  reg_gmac_3v3: gmac-3v3 {
 &emac {
 	pinctrl-names = "default";
 	pinctrl-0 = <&ext_rgmii_pins>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&ext_rgmii_phy>;
 	phy-supply = <&reg_gmac_3v3>;
 	allwinner,rx-delay-ps = <200>;