Add a second working PNP_ID for a T470s

Commit Message

[e-mail] March 30, 2020, 4:21 p.m. UTC

The Lenovo Thinkpad T470s I own has a different touchpad with "LEN007a" instead of the already included PNP ID "LEN006c". However, my touchpad seems to work well without any problems using RMI. So this patch adds the other PNP ID.

Signed-off-by: Dennis Kadioglu <[e-mail]>
---
 drivers/input/mouse/synaptics.c | 1 +
 1 file changed, 1 insertion(+)

---­

---

Comments

[e-mail] April 24, 2020, 12:54 p.m. UTC | #1

I'd like to ask, if my proposed small patch can be incorporated. Is there anything missing or to be improved?

Thanks and best
denk


--- Ursprüngliche Nachricht ---
Von: " " <[e-mail]>
Datum: 30.03.2020 18:21:47
An: <[e-mail]>
Betreff: Add a second working PNP_ID for a T470s

The Lenovo Thinkpad T470s I own has a different touchpad with "LEN007a"
instead of the already included PNP ID "LEN006c". However, my touchpad
seems to work well without any problems using RMI. So this patch adds the
other PNP ID.

Signed-off-by: Dennis Kadioglu <[e-mail]>
---
 drivers/input/mouse/synaptics.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c

index 4d2036209b45d..758dae8d65006 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = {
 	"LEN005b", /* P50 */
 	"LEN005e", /* T560 */
 	"LEN006c", /* T470s */
+	"LEN007a", /* T470s */
 	"LEN0071", /* T480 */
 	"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */

 	"LEN0073", /* X1 Carbon G5 (Elantech) */
---­

---

Dmitry Torokhov April 24, 2020, 10:25 p.m. UTC | #2

Hi Dennis,

On Mon, Mar 30, 2020 at 06:21:47PM +0200,   wrote:
> The Lenovo Thinkpad T470s I own has a different touchpad with
> "LEN007a" instead of the already included PNP ID "LEN006c". However,
> my touchpad seems to work well without any problems using RMI. So this
> patch adds the other PNP ID.

So there are no visible issues when running the touchpad in PS/2 mode
compared to RMI4? (Just trying to figure out if it needs to go into
stable releases).

Do you know what trackpoint does the device have? 

Thanks.

[e-mail] April 25, 2020, 6:13 a.m. UTC | #3

Hi Dmitry,

thanks for your reply. In the following I just add the content of my first email to this list:
#####
In dmesg I found the following:
psmouse serio1: synaptics: Your touchpad (PNP: LEN007a PNP0f13) says it can support a different bus. If i2c-hid and hid-rmi are not used, you might want to try setting psmouse.synaptics_intertouch to 1 and report this to [e-mail].

After setting psmouse.synaptics_intertouch=1, touchpad and trackpoint still work fine. Also no problems with suspending my laptop.

The only problem is the following error meesage on shutdown:
rmi4_physical rmi4-00: Failed to read irqs, code=-6

/proc/bus/input/devices:
I: Bus=001d Vendor=06cb Product=0000 Version=0000
N: Name="Synaptics TM3145-006"
P: Phys=rmi4-00/input0
S: Sysfs=/devices/rmi4-00/input/input26
U: Uniq=
H: Handlers=event18 mouse0
B: PROP=5
B: EV=b
B: KEY=e520 10000 0 0 0 0
B: ABS=6f3800001000003

I: Bus=0011 Vendor=0002 Product=000a Version=0000
N: Name="TPPS/2 IBM TrackPoint"
P: Phys=rmi4-00.fn03/serio0/input0
S: Sysfs=/devices/rmi4-00/rmi4-00.fn03/serio2/input/input27
U: Uniq=
H: Handlers=event19 mouse1
B: PROP=21
B: EV=7
B: KEY=70000 0 0 0 0
B: REL=3

Is there anything I can do, that the error messsage doesn't appear anymore? Should I not use RMI?
#####

As far as I can see, there is no issue running the touchpad with RMI4. The only difference to running it in PS/2 mode is the mentioned error message during shutdown. Is that error message only cosmetic, or a real issue? Can something be done to omit this error message?
Regarding the touchpad, is the above pasted information sufficient, or do you need anything else?

Thanks and best
Dennis


--- Ursprüngliche Nachricht ---
Von: Dmitry Torokhov <[e-mail]>
Datum: 25.04.2020 00:25:46
An: <[e-mail]>
Betreff: Re: Add a second working PNP_ID for a T470s

Hi Dennis,

On Mon, Mar 30, 2020 at 06:21:47PM +0200,   wrote:
> The Lenovo Thinkpad T470s I own has a different touchpad with
> "LEN007a" instead of the already included PNP ID "LEN006c".
However,
> my touchpad seems to work well without any problems using RMI. So this

> patch adds the other PNP ID.

So there are no visible issues when running the touchpad in PS/2 mode
compared to RMI4? (Just trying to figure out if it needs to go into
stable releases).

Do you know what trackpoint does the device have? 

Thanks.

[e-mail] May 22, 2020, 11:42 a.m. UTC | #4

Hi Dmitry,

as far as I can see, there was no reply from you. If so, then I may have missed that, sorry for that.
As I said I am not aware of any issues when running the touchpad and trackpoint with RMI4. The only difference is the mentioned error message during shutdown, which I would like to get rid of, if possible.
Can the patch be merged? Anything missing for that?

Thanks and best
Dennis


--- Ursprüngliche Nachricht ---
Von: " " <[e-mail]>
Datum: 25.04.2020 08:13:31
An: "Dmitry Torokhov" <[e-mail]>
Betreff: Re: Re: Add a second working PNP_ID for a T470s

Hi Dmitry,

thanks for your reply. In the following I just add the content of my first
email to this list:
#####
In dmesg I found the following:
psmouse serio1: synaptics: Your touchpad (PNP: LEN007a PNP0f13) says it can
support a different bus. If i2c-hid and hid-rmi are not used, you might want
to try setting psmouse.synaptics_intertouch to 1 and report this to [e-mail].


After setting psmouse.synaptics_intertouch=1, touchpad and trackpoint still
work fine. Also no problems with suspending my laptop.

The only problem is the following error meesage on shutdown:
rmi4_physical rmi4-00: Failed to read irqs, code=-6

/proc/bus/input/devices:
I: Bus=001d Vendor=06cb Product=0000 Version=0000
N: Name="Synaptics TM3145-006"
P: Phys=rmi4-00/input0
S: Sysfs=/devices/rmi4-00/input/input26
U: Uniq=
H: Handlers=event18 mouse0
B: PROP=5
B: EV=b
B: KEY=e520 10000 0 0 0 0
B: ABS=6f3800001000003

I: Bus=0011 Vendor=0002 Product=000a Version=0000
N: Name="TPPS/2 IBM TrackPoint"
P: Phys=rmi4-00.fn03/serio0/input0
S: Sysfs=/devices/rmi4-00/rmi4-00.fn03/serio2/input/input27
U: Uniq=
H: Handlers=event19 mouse1
B: PROP=21
B: EV=7
B: KEY=70000 0 0 0 0
B: REL=3

Is there anything I can do, that the error messsage doesn't appear anymore?
Should I not use RMI?
#####

As far as I can see, there is no issue running the touchpad with RMI4. The
only difference to running it in PS/2 mode is the mentioned error message
during shutdown. Is that error message only cosmetic, or a real issue? Can
something be done to omit this error message?
Regarding the touchpad, is the above pasted information sufficient, or do
you need anything else?

Thanks and best
Dennis


--- Ursprüngliche Nachricht ---
Von: Dmitry Torokhov <[e-mail]>
Datum: 25.04.2020 00:25:46
An: <[e-mail]>
Betreff: Re: Add a second working PNP_ID for a T470s

Hi Dennis,

On Mon, Mar 30, 2020 at 06:21:47PM +0200,   wrote:
> The Lenovo Thinkpad T470s I own has a different touchpad with
> "LEN007a" instead of the already included PNP ID "LEN006c".

However,
> my touchpad seems to work well without any problems using RMI. So this


> patch adds the other PNP ID.

So there are no visible issues when running the touchpad in PS/2 mode
compared to RMI4? (Just trying to figure out if it needs to go into
stable releases).

Do you know what trackpoint does the device have? 

Thanks.

Dmitry Torokhov May 27, 2020, 6:10 a.m. UTC | #5

Hi Dennis,

On Fri, May 22, 2020 at 01:42:35PM +0200,   wrote:
> Hi Dmitry,
> 
> as far as I can see, there was no reply from you. If so, then I may have missed that, sorry for that.
> As I said I am not aware of any issues when running the touchpad and trackpoint with RMI4. The only difference is the mentioned error message during shutdown, which I would like to get rid of, if possible.
> Can the patch be merged? Anything missing for that?

Sorry, my fault as I have been busy lately and my patch queue grew
really long. The patch is applied, thank you for your work (and
patience).

Thanks.

[e-mail] May 27, 2020, 12:28 p.m. UTC | #6

Hi Dmitry,

thank you very much!
Regarding my additional question about the error message: Is it possible, to omit this error on shutdown?

Thanks and best
Dennis

--- Ursprüngliche Nachricht ---
Von: Dmitry Torokhov <[e-mail]>
Datum: 27.05.2020 08:10:19
An: <[e-mail]>
Betreff: Re: Re: Re: Add a second working PNP_ID for a T470s

Hi Dennis,

On Fri, May 22, 2020 at 01:42:35PM +0200,   wrote:
> Hi Dmitry,
> 
> as far as I can see, there was no reply from you. If so, then I may
have missed that, sorry for that.
> As I said I am not aware of any issues when running the touchpad and
trackpoint with RMI4. The only difference is the mentioned error message
during shutdown, which I would like to get rid of, if possible.
> Can the patch be merged? Anything missing for that?

Sorry, my fault as I have been busy lately and my patch queue grew
really long. The patch is applied, thank you for your work (and
patience).

Thanks.

[e-mail] May 27, 2020, 12:29 p.m. UTC | #7

Hi Dmitry,

thank you very much!
Regarding my additional question about the error message: Is it possible, to omit this error on shutdown?

Thanks and best
Dennis


--- Ursprüngliche Nachricht ---
Von: Dmitry Torokhov <[e-mail]>
Datum: 27.05.2020 08:10:19
An: <[e-mail]>
Betreff: Re: Re: Re: Add a second working PNP_ID for a T470s

Hi Dennis,

On Fri, May 22, 2020 at 01:42:35PM +0200,   wrote:
> Hi Dmitry,
> 
> as far as I can see, there was no reply from you. If so, then I may
have missed that, sorry for that.
> As I said I am not aware of any issues when running the touchpad and
trackpoint with RMI4. The only difference is the mentioned error message
during shutdown, which I would like to get rid of, if possible.
> Can the patch be merged? Anything missing for that?

Sorry, my fault as I have been busy lately and my patch queue grew
really long. The patch is applied, thank you for your work (and
patience).

Thanks.

[e-mail] June 8, 2020, 9:05 a.m. UTC | #8

Hi again,

is there anything I can do to omit the error message (rmi4_physical rmi4-00: Failed to read irqs, code=-6) on shutdown?

Thanks and best
Dennis


--- Ursprüngliche Nachricht ---
Von: " " <[e-mail]>
Datum: 27.05.2020 14:29:24
An: "Dmitry Torokhov" <[e-mail]>
Betreff: Re: Re: Re: Re: Add a second working PNP_ID for a T470s

Hi Dmitry,

thank you very much!
Regarding my additional question about the error message: Is it possible,
to omit this error on shutdown?

Thanks and best
Dennis


--- Ursprüngliche Nachricht ---
Von: Dmitry Torokhov <[e-mail]>
Datum: 27.05.2020 08:10:19
An: <[e-mail]>
Betreff: Re: Re: Re: Add a second working PNP_ID for a T470s

Hi Dennis,

On Fri, May 22, 2020 at 01:42:35PM +0200,   wrote:
> Hi Dmitry,
> 
> as far as I can see, there was no reply from you. If so, then I may

have missed that, sorry for that.
> As I said I am not aware of any issues when running the touchpad and

trackpoint with RMI4. The only difference is the mentioned error message

during shutdown, which I would like to get rid of, if possible.
> Can the patch be merged? Anything missing for that?

Sorry, my fault as I have been busy lately and my patch queue grew
really long. The patch is applied, thank you for your work (and
patience).

Thanks.

[e-mail] Nov. 2, 2020, 11:28 a.m. UTC | #9

Hi again,

as I never got any reply, I would like to ask again, if there is anything I can do to omit the error message (rmi4_physical rmi4-00:
Failed to read irqs, code=-6) on shutdown?

Thank you very much and best
Dennis


--- Ursprüngliche Nachricht ---
Von: " " <[e-mail]>
Datum: 08.06.2020 11:05:54
An: <[e-mail]>
Betreff: Re: Re: Re: Re: Re: Add a second working PNP_ID for a T470s

Hi again,

is there anything I can do to omit the error message (rmi4_physical rmi4-00:
Failed to read irqs, code=-6) on shutdown?

Thanks and best
Dennis


--- Ursprüngliche Nachricht ---
Von: " " <[e-mail]>
Datum: 27.05.2020 14:29:24
An: "Dmitry Torokhov" <[e-mail]>
Betreff: Re: Re: Re: Re: Add a second working PNP_ID for a T470s

Hi Dmitry,

thank you very much!
Regarding my additional question about the error message: Is it possible,

to omit this error on shutdown?

Thanks and best
Dennis


--- Ursprüngliche Nachricht ---
Von: Dmitry Torokhov <[e-mail]>
Datum: 27.05.2020 08:10:19
An: <[e-mail]>
Betreff: Re: Re: Re: Add a second working PNP_ID for a T470s

Hi Dennis,

On Fri, May 22, 2020 at 01:42:35PM +0200,   wrote:
> Hi Dmitry,
> 
> as far as I can see, there was no reply from you. If so, then I may


have missed that, sorry for that.
> As I said I am not aware of any issues when running the touchpad and


trackpoint with RMI4. The only difference is the mentioned error message


during shutdown, which I would like to get rid of, if possible.
> Can the patch be merged? Anything missing for that?

Sorry, my fault as I have been busy lately and my patch queue grew
really long. The patch is applied, thank you for your work (and
patience).

Thanks.

Patch

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 4d2036209b45d..758dae8d65006 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -170,6 +170,7 @@  static const char * const smbus_pnp_ids[] = {
 	"LEN005b", /* P50 */
 	"LEN005e", /* T560 */
 	"LEN006c", /* T470s */
+	"LEN007a", /* T470s */
 	"LEN0071", /* T480 */
 	"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
 	"LEN0073", /* X1 Carbon G5 (Elantech) */