| Message ID | 20201103162435.13689-6-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [1/8] clk: pwm: drop of_match_ptr from of_device_id table | expand |
Hi Krzysztof, On Tue, Nov 3, 2020 at 5:25 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > The function rcar_r8a779a0_cpg_clk_register() is not used outside of the > unit so it can be made static to fix compilation warning: > > drivers/clk/renesas/r8a779a0-cpg-mssr.c:156:21: warning: > no previous prototype for ‘rcar_r8a779a0_cpg_clk_register’ [-Wmissing-prototypes] > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Thanks for your patch! A fix for this is already queued in renesas-clk-for-v5.11: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=renesas-clk-for-v5.11&id=c3f207f6d23d01c0fa817fcd6118bbbc509abe39 Gr{oetje,eeting}s, Geert
diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers/clk/renesas/r8a779a0-cpg-mssr.c index 17ebbac7ddfb..7e25b3b8945b 100644 --- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c +++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c @@ -153,7 +153,7 @@ static const struct rcar_r8a779a0_cpg_pll_config *cpg_pll_config __initdata; static unsigned int cpg_clk_extalr __initdata; static u32 cpg_mode __initdata; -struct clk * __init rcar_r8a779a0_cpg_clk_register(struct device *dev, +static struct clk * __init rcar_r8a779a0_cpg_clk_register(struct device *dev, const struct cpg_core_clk *core, const struct cpg_mssr_info *info, struct clk **clks, void __iomem *base, struct raw_notifier_head *notifiers)
The function rcar_r8a779a0_cpg_clk_register() is not used outside of the unit so it can be made static to fix compilation warning: drivers/clk/renesas/r8a779a0-cpg-mssr.c:156:21: warning: no previous prototype for ‘rcar_r8a779a0_cpg_clk_register’ [-Wmissing-prototypes] Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/clk/renesas/r8a779a0-cpg-mssr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)