| Message ID | 20201104090610.1446616-7-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/12] net: usb: lan78xx: Remove lots of set but unused 'ret' variables | expand |
On Wed, Nov 04, 2020 at 09:06:04AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set' > > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: netdev@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> I _think_ these have got missed so far in the various cleanup passes because of missing COMPILE_TEST. I've been adding that as part of fixing these warnings. When your respin, could you add that as well? Thanks Andrew
On Wed, 04 Nov 2020, Andrew Lunn wrote: > On Wed, Nov 04, 2020 at 09:06:04AM +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set' > > > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: Jakub Kicinski <kuba@kernel.org> > > Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > > Cc: netdev@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > I _think_ these have got missed so far in the various cleanup passes > because of missing COMPILE_TEST. I've been adding that as part of > fixing these warnings. When your respin, could you add that as well? Yes, no problem. Just for this symbol?
On Wed, Nov 04, 2020 at 02:28:35PM +0000, Lee Jones wrote: > On Wed, 04 Nov 2020, Andrew Lunn wrote: > > > On Wed, Nov 04, 2020 at 09:06:04AM +0000, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set' > > > > > > Cc: "David S. Miller" <davem@davemloft.net> > > > Cc: Jakub Kicinski <kuba@kernel.org> > > > Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > > > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > > > Cc: netdev@vger.kernel.org > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > > > I _think_ these have got missed so far in the various cleanup passes > > because of missing COMPILE_TEST. I've been adding that as part of > > fixing these warnings. When your respin, could you add that as well? > > Yes, no problem. > > Just for this symbol? Hi Lee I've not look at the Kbuild, but ideally so that all TI drivers get built when COMPILE_TEST is true. And this probably needs to happen for any patch i added a Reviewed-by: because i missed them as well. I'm using COMPILE_TEST but just for arm and x86, where as i guess you are using more randconfig builds, or less popular architectures? Andrew
On Wed, 04 Nov 2020, Andrew Lunn wrote: > On Wed, Nov 04, 2020 at 02:28:35PM +0000, Lee Jones wrote: > > On Wed, 04 Nov 2020, Andrew Lunn wrote: > > > > > On Wed, Nov 04, 2020 at 09:06:04AM +0000, Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' > > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set' > > > > > > > > Cc: "David S. Miller" <davem@davemloft.net> > > > > Cc: Jakub Kicinski <kuba@kernel.org> > > > > Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > > > > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > > > > Cc: netdev@vger.kernel.org > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > > > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > > > > > I _think_ these have got missed so far in the various cleanup passes > > > because of missing COMPILE_TEST. I've been adding that as part of > > > fixing these warnings. When your respin, could you add that as well? > > > > Yes, no problem. > > > > Just for this symbol? > > Hi Lee > > I've not look at the Kbuild, but ideally so that all TI drivers get > built when COMPILE_TEST is true. > > And this probably needs to happen for any patch i added a Reviewed-by: > because i missed them as well. I'm using COMPILE_TEST but just for arm > and x86, where as i guess you are using more randconfig builds, or > less popular architectures? I'm doing 'allmodconfig' builds for; arm, arm64, mips, ppc and x86.
diff --git a/drivers/net/ethernet/ti/am65-cpsw-qos.c b/drivers/net/ethernet/ti/am65-cpsw-qos.c index 3bdd4dbcd2ff1..ebcc6386cc34a 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-qos.c +++ b/drivers/net/ethernet/ti/am65-cpsw-qos.c @@ -356,7 +356,7 @@ static void am65_cpsw_est_set_sched_list(struct net_device *ndev, writel(~all_fetch_allow & AM65_CPSW_FETCH_ALLOW_MSK, ram_addr); } -/** +/* * Enable ESTf periodic output, set cycle start time and interval. */ static int am65_cpsw_timer_set(struct net_device *ndev,
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set' Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/net/ethernet/ti/am65-cpsw-qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)