| Message ID | 1604054832-3114-3-git-send-email-akhilpo@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v5,1/3] drm/msm: Add support for GPU cooling | expand |
On Fri, 30 Oct 2020 16:17:12 +0530, Akhil P Oommen wrote: > Add cooling device support to gpu. A cooling device is bound to a > thermal zone to allow thermal mitigation. > > Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > --- > Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
On Wed, Nov 4, 2020 at 12:03 PM Rob Herring <robh@kernel.org> wrote: > > On Fri, 30 Oct 2020 16:17:12 +0530, Akhil P Oommen wrote: > > Add cooling device support to gpu. A cooling device is bound to a > > thermal zone to allow thermal mitigation. > > > > Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org> > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > > --- > > Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. > Thanks Rob I've copied over your ack from the previous version.. but yes, it definitely makes my life easier when patch senders do this for me ;-) BR, -R
On 11/5/2020 2:28 AM, Rob Clark wrote: > On Wed, Nov 4, 2020 at 12:03 PM Rob Herring <robh@kernel.org> wrote: >> >> On Fri, 30 Oct 2020 16:17:12 +0530, Akhil P Oommen wrote: >>> Add cooling device support to gpu. A cooling device is bound to a >>> thermal zone to allow thermal mitigation. >>> >>> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org> >>> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> >>> --- >>> Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >> >> >> Please add Acked-by/Reviewed-by tags when posting new versions. However, >> there's no need to repost patches *only* to add the tags. The upstream >> maintainer will do that for acks received on the version they apply. >> >> If a tag was not added on purpose, please state why and what changed. >> > > > Thanks Rob > > I've copied over your ack from the previous version.. but yes, it > definitely makes my life easier when patch senders do this for me ;-) > > BR, > -R > Robh, you Acked v4 after I shared v5 patches!! -Akhil.
diff --git a/Documentation/devicetree/bindings/display/msm/gpu.txt b/Documentation/devicetree/bindings/display/msm/gpu.txt index 1af0ff1..090dcb3 100644 --- a/Documentation/devicetree/bindings/display/msm/gpu.txt +++ b/Documentation/devicetree/bindings/display/msm/gpu.txt @@ -39,6 +39,10 @@ Required properties: a4xx Snapdragon SoCs. See Documentation/devicetree/bindings/sram/qcom,ocmem.yaml. +Optional properties: +- #cooling-cells: The value must be 2. For details, please refer + Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml. + Example 3xx/4xx: / { @@ -61,6 +65,7 @@ Example 3xx/4xx: power-domains = <&mmcc OXILICX_GDSC>; operating-points-v2 = <&gpu_opp_table>; iommus = <&gpu_iommu 0>; + #cooling-cells = <2>; }; gpu_sram: ocmem@fdd00000 { @@ -98,6 +103,8 @@ Example a6xx (with GMU): reg = <0x5000000 0x40000>, <0x509e000 0x10>; reg-names = "kgsl_3d0_reg_memory", "cx_mem"; + #cooling-cells = <2>; + /* * Look ma, no clocks! The GPU clocks and power are * controlled entirely by the GMU