libfc: fix enum-conversion warning

Commit Message

Arnd Bergmann Oct. 26, 2020, 9:49 p.m. UTC

From: Arnd Bergmann <[e-mail]>

gcc -Wextra points out an assignment between two different
enum types:

drivers/scsi/libfc/fc_exch.c: In function 'fc_exch_setup_hdr':
../drivers/scsi/libfc/fc_exch.c:275:26: warning: implicit conversion from 'enum fc_class' to 'enum fc_sof' [-Wenum-conversion]

This seems to be intentional, as the same numeric values are
used here, so shut up the warning by adding an explicit cast.

Fixes: 42e9a92fe6a9 ("[SCSI] libfc: A modular Fibre Channel library")
Signed-off-by: Arnd Bergmann <[e-mail]>
---
 drivers/scsi/libfc/fc_exch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Oct. 30, 2020, 1:52 a.m. UTC | #1

Arnd,

> gcc -Wextra points out an assignment between two different
> enum types:

Applied to 5.11/scsi-staging, thanks!

Martin K. Petersen Nov. 5, 2020, 4:21 a.m. UTC | #2

On Mon, 26 Oct 2020 22:49:07 +0100, Arnd Bergmann wrote:

> gcc -Wextra points out an assignment between two different
> enum types:
> 
> drivers/scsi/libfc/fc_exch.c: In function 'fc_exch_setup_hdr':
> ../drivers/scsi/libfc/fc_exch.c:275:26: warning: implicit conversion from 'enum fc_class' to 'enum fc_sof' [-Wenum-conversion]
> 
> This seems to be intentional, as the same numeric values are
> used here, so shut up the warning by adding an explicit cast.

Applied to 5.11/scsi-queue, thanks!

[1/1] scsi: libfc: Fix enum-conversion warning
      https://git.kernel.org/mkp/scsi/c/3fb52041a832

Patch

diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
index 91e680b53523..d71afae6191c 100644
--- a/drivers/scsi/libfc/fc_exch.c
+++ b/drivers/scsi/libfc/fc_exch.c
@@ -271,7 +271,7 @@  static void fc_exch_setup_hdr(struct fc_exch *ep, struct fc_frame *fp,
 
 	if (f_ctl & FC_FC_END_SEQ) {
 		fr_eof(fp) = FC_EOF_T;
-		if (fc_sof_needs_ack(ep->class))
+		if (fc_sof_needs_ack((enum fc_sof)ep->class))
 			fr_eof(fp) = FC_EOF_N;
 		/*
 		 * From F_CTL.