diff mbox series

arm64: Fix a broken copyright header in gen_vdso_offsets.sh

Message ID 20201017002637.503579-1-palmer@dabbelt.com (mailing list archive)
State New, archived
Headers show
Series arm64: Fix a broken copyright header in gen_vdso_offsets.sh | expand

Commit Message

Palmer Dabbelt Oct. 17, 2020, 12:26 a.m. UTC 
From: Palmer Dabbelt <palmerdabbelt@google.com>

I was going to copy this but I didn't want to chase around the build
system stuff so I did it a different way.

Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
 arch/arm64/kernel/vdso/gen_vdso_offsets.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Will Deacon Oct. 20, 2020, 11:32 a.m. UTC | #1 
On Fri, Oct 16, 2020 at 05:26:37PM -0700, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@google.com>
> 
> I was going to copy this but I didn't want to chase around the build
> system stuff so I did it a different way.

How did you end up doing it? I remember trying to parse the ELF object at
one time of day and not getting very far.

Will
Will Deacon Oct. 20, 2020, 5:57 p.m. UTC | #2 
On Fri, 16 Oct 2020 17:26:37 -0700, Palmer Dabbelt wrote:
> I was going to copy this but I didn't want to chase around the build
> system stuff so I did it a different way.

Applied to arm64 (for-next/core), thanks!

[1/1] arm64: Fix a broken copyright header in gen_vdso_offsets.sh
      https://git.kernel.org/arm64/c/7bdf468a5b40

Cheers,
Palmer Dabbelt Nov. 6, 2020, 2:48 a.m. UTC | #3 
On Tue, 20 Oct 2020 04:32:08 PDT (-0700), will@kernel.org wrote:
> On Fri, Oct 16, 2020 at 05:26:37PM -0700, Palmer Dabbelt wrote:
>> From: Palmer Dabbelt <palmerdabbelt@google.com>
>>
>> I was going to copy this but I didn't want to chase around the build
>> system stuff so I did it a different way.
>
> How did you end up doing it? I remember trying to parse the ELF object at
> one time of day and not getting very far.

Mine really isn't any cleaner: I use nm and sed to produce an assembler file
full of absolute symbols, which I compile to produce the object.  That way I
don't need a header file, which means I don't need to mess around with build
ordering or change any of the other code (which was already using symbols).

I don't really like this whole thing we do where we just assume that symbols
with a small offset from absolute address zero.  We're sort of depending on
that for undefined weak symbols, but that's only for actually zero not almost
zero.  Given that, I figured it'd be easier to just do it this way rather than
trying to mess with build stuff.

I probably wouldn't bother changing unless there's something actively bad about
that build stuff (I didn't really look).
diff mbox series

Patch

diff --git a/arch/arm64/kernel/vdso/gen_vdso_offsets.sh b/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
index 0664acaf61ff..8b806eacd0a6 100755
--- a/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
+++ b/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
@@ -8,7 +8,7 @@ 
 # Doing this inside the Makefile will break the $(filter-out) function,
 # causing Kbuild to rebuild the vdso-offsets header file every time.
 #
-# Author: Will Deacon <will.deacon@arm.com
+# Author: Will Deacon <will.deacon@arm.com>
 #
 
 LC_ALL=C