| Message ID | 20201031175836.47745-2-martin.juecker@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | add exynos4412-based p4note device family support | expand |
On Sat, 31 Oct 2020 18:58:33 +0100, Martin Jücker wrote: > Document the GT-N8010/GT-N8013 device binding and the p4note common > binding that it is based on. > > Signed-off-by: Martin Jücker <martin.juecker@gmail.com> > --- > .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
On Wed, Nov 04, 2020 at 02:03:48PM -0600, Rob Herring wrote: > On Sat, 31 Oct 2020 18:58:33 +0100, Martin Jücker wrote: > > Document the GT-N8010/GT-N8013 device binding and the p4note common > > binding that it is based on. > > > > Signed-off-by: Martin Jücker <martin.juecker@gmail.com> > > --- > > .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. > I wasn't aware of this but it makes sense. I actually changed the board compatible from samsung,n801x to samsung,n8010 - I guess that would still be ok to add a reviewed-by in this case? Cheers Martin
diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml index eb92f9eefaba..dbc401984152 100644 --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml @@ -83,6 +83,14 @@ properties: - const: samsung,exynos4412 - const: samsung,exynos4 + - description: Samsung p4note family boards + items: + - enum: + - samsung,n8010 # Samsung GT-N8010/GT-N8013 + - const: samsung,p4note + - const: samsung,exynos4412 + - const: samsung,exynos4 + - description: Exynos5250 based boards items: - enum:
Document the GT-N8010/GT-N8013 device binding and the p4note common binding that it is based on. Signed-off-by: Martin Jücker <martin.juecker@gmail.com> --- .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)