diff mbox series

ath11k: Remove unnecessary data sync to cpu on monitor buffer

Message ID 1602744454-22969-1-git-send-email-vthiagar@codeaurora.org (mailing list archive)
State Accepted
Commit bafdbd79aae4c91f38caa43e5fb7abfd911f5bf6
Delegated to: Kalle Valo
Headers show
Series ath11k: Remove unnecessary data sync to cpu on monitor buffer | expand

Commit Message

Vasanthakumar Thiagarajan Oct. 15, 2020, 6:47 a.m. UTC
Monitor ring Rx buffer is not really modified between dma map
and unmap. So remove the unnecssary data sync before dma unmap.
This does not fix any visible issue, found in code review.

Compile tested only.

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Kalle Valo Nov. 7, 2020, 7:59 a.m. UTC | #1
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> wrote:

> Monitor ring Rx buffer is not really modified between dma map
> and unmap. So remove the unnecssary data sync before dma unmap.
> This does not fix any visible issue, found in code review.
> 
> Compile tested only.
> 
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

bafdbd79aae4 ath11k: Remove unnecessary data sync to cpu on monitor buffer
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 0162532..4455e5af 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -2856,10 +2856,6 @@  static int ath11k_dp_rx_reap_mon_status_ring(struct ath11k_base *ab, int mac_id,
 
 			rxcb = ATH11K_SKB_RXCB(skb);
 
-			dma_sync_single_for_cpu(ab->dev, rxcb->paddr,
-						skb->len + skb_tailroom(skb),
-						DMA_FROM_DEVICE);
-
 			dma_unmap_single(ab->dev, rxcb->paddr,
 					 skb->len + skb_tailroom(skb),
 					 DMA_BIDIRECTIONAL);