diff mbox series

[19/20] input: keyboard: nomadik-ske-keypad: Provide some missing struct member docs

Message ID 20201104162427.2984742-20-lee.jones@linaro.org (mailing list archive)
State Superseded
Commit 5b27585a8524cbb1c720502d3014a5fb85951ab9
Headers show
Series Rid W=1 issues from Input | expand

Commit Message

Lee Jones Nov. 4, 2020, 4:24 p.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/input/keyboard/nomadik-ske-keypad.c:71: warning: Function parameter or member 'pclk' not described in 'ske_keypad'
 drivers/input/keyboard/nomadik-ske-keypad.c:71: warning: Function parameter or member 'ske_keypad_lock' not described in 'ske_keypad'

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Kumar G <naveen.gaddipati@stericsson.com>
Cc: Sundar Iyer <sundar.iyer@stericsson.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/input/keyboard/nomadik-ske-keypad.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dmitry Torokhov Nov. 9, 2020, 6:18 a.m. UTC | #1
On Wed, Nov 04, 2020 at 04:24:26PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/input/keyboard/nomadik-ske-keypad.c:71: warning: Function parameter or member 'pclk' not described in 'ske_keypad'
>  drivers/input/keyboard/nomadik-ske-keypad.c:71: warning: Function parameter or member 'ske_keypad_lock' not described in 'ske_keypad'
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Kumar G <naveen.gaddipati@stericsson.com>
> Cc: Sundar Iyer <sundar.iyer@stericsson.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/keyboard/nomadik-ske-keypad.c b/drivers/input/keyboard/nomadik-ske-keypad.c
index 608446e14614d..0d55a95347f16 100644
--- a/drivers/input/keyboard/nomadik-ske-keypad.c
+++ b/drivers/input/keyboard/nomadik-ske-keypad.c
@@ -58,6 +58,8 @@ 
  * @board:	keypad platform device
  * @keymap:	matrix scan code table for keycodes
  * @clk:	clock structure pointer
+ * @pclk:	clock structure pointer
+ * @ske_keypad_lock: spinlock protecting the keypad read/writes
  */
 struct ske_keypad {
 	int irq;