| Message ID | 20201104202952.783724-2-npcomplete13@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl | expand |
On Wed, 4 Nov 2020 at 21:30, Vivek Unune <npcomplete13@gmail.com> wrote: > BCM47094 version of pinmux uses different driver and supports mdio > pinmux pins. Hence, use the correct driver and define the pins. > > Signed-off-by: Vivek Unune <npcomplete13@gmail.com> Subject and message are a bit confusing as it's actually a matter of chipset specific binding and not a driver. Change looks OK, thanks for handling that! Acked-by: Rafał Miłecki <rafal@milecki.pl>
On 11/9/20 9:21 AM, Rafał Miłecki wrote: > On Wed, 4 Nov 2020 at 21:30, Vivek Unune <npcomplete13@gmail.com> wrote: >> BCM47094 version of pinmux uses different driver and supports mdio >> pinmux pins. Hence, use the correct driver and define the pins. >> >> Signed-off-by: Vivek Unune <npcomplete13@gmail.com> > > Subject and message are a bit confusing as it's actually a matter of > chipset specific binding and not a driver. > > Change looks OK, thanks for handling that! > > Acked-by: Rafał Miłecki <rafal@milecki.pl> > Agreed, applied and fixed up the subject and commit message this way: ARM: dts: BCM5301X: Use corretc pinctrl compatible for 4709x BCM47094 version of pinmux uses different compatible and supports MDIO pinmux pins. Hence, use the correct compatible string and defines the MDIO pins group. Thanks!
diff --git a/arch/arm/boot/dts/bcm47094.dtsi b/arch/arm/boot/dts/bcm47094.dtsi index cdc5ff593adb..747ca030435f 100644 --- a/arch/arm/boot/dts/bcm47094.dtsi +++ b/arch/arm/boot/dts/bcm47094.dtsi @@ -8,6 +8,15 @@ / { }; +&pinctrl { + compatible = "brcm,bcm4709-pinmux"; + + pinmux_mdio: mdio { + groups = "mdio_grp"; + function = "mdio"; + }; +}; + &usb3_phy { compatible = "brcm,ns-bx-usb3-phy"; }; diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi index 3e55ff4fb550..cfc08cdd590f 100644 --- a/arch/arm/boot/dts/bcm5301x.dtsi +++ b/arch/arm/boot/dts/bcm5301x.dtsi @@ -428,7 +428,7 @@ cru@100 { #address-cells = <1>; #size-cells = <1>; - pin-controller@1c0 { + pinctrl: pin-controller@1c0 { compatible = "brcm,bcm4708-pinmux"; reg = <0x1c0 0x24>; reg-names = "cru_gpio_control";
BCM47094 version of pinmux uses different driver and supports mdio pinmux pins. Hence, use the correct driver and define the pins. Signed-off-by: Vivek Unune <npcomplete13@gmail.com> --- --- arch/arm/boot/dts/bcm47094.dtsi | 9 +++++++++ arch/arm/boot/dts/bcm5301x.dtsi | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-)