| Message ID | 20201106072551.689-1-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: ti: davinci-mcasp: Handle incomplete DT node gracefully | expand |
On Fri, 6 Nov 2020 09:25:47 +0200, Peter Ujfalusi wrote: > The series is inspired by the effort to standardize TI's arm64 dtsi files to keep > all nodes in 'okay' state and let the board dts files disable not needed > peripherals (and not properly configured): > https://lore.kernel.org/lkml/20201104224356.18040-1-nm@ti.com/ > > In the unlikely (or likely?) event when the dts misses to disable the McASP node > which is not configured we currenly and luckily just manage to not crash as we > had fixup code in place for legacy pdata boots. > This however prints out a message which does not really help to identify the > issue. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/4] ASoC: ti: davinci-mcasp: Use platform_get_irq_byname_optional commit: 372c4bd11de1793667e11d19c29fffc80495eeca [2/4] ASoC: ti: davinci-mcasp: Remove legacy dma_request parsing commit: db8793a39b293d5a8983e1713a70a76cb039c2fe [3/4] ASoC: ti: davinci-mcasp: Simplify the configuration parameter handling commit: 1125d925990b8d8166c45396c9281e2a705c97f8 [4/4] ASoC: ti: davinci-mcasp: Handle missing required DT properties commit: 1b4fb70e5b28a477478417a7958e0228460ffe68 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi, The series is inspired by the effort to standardize TI's arm64 dtsi files to keep all nodes in 'okay' state and let the board dts files disable not needed peripherals (and not properly configured): https://lore.kernel.org/lkml/20201104224356.18040-1-nm@ti.com/ In the unlikely (or likely?) event when the dts misses to disable the McASP node which is not configured we currenly and luckily just manage to not crash as we had fixup code in place for legacy pdata boots. This however prints out a message which does not really help to identify the issue. This series will reduce some of the noise during boot (first patch) then adds the needed changes to handle the variations of 'okay': A - have all required DT properties for audio B - gpiochip is enabled A && !B -> everything is OK for audio, no gpiochip registered A && B -> everything is OK for audio, gpiochip is registered !A && B -> audio is not OK, gpiochip is registered. dev_dbg() for audio and do not register SOC DAI and PCM !A && !B -> audio is not OK, no gpiochip. dev_err() and fail the probe Regards, Peter --- Peter Ujfalusi (4): ASoC: ti: davinci-mcasp: Use platform_get_irq_byname_optional ASoC: ti: davinci-mcasp: Remove legacy dma_request parsing ASoC: ti: davinci-mcasp: Simplify the configuration parameter handling ASoC: ti: davinci-mcasp: Handle missing required DT properties sound/soc/ti/davinci-mcasp.c | 294 ++++++++++++++--------------------- 1 file changed, 119 insertions(+), 175 deletions(-)