| Message ID | 20201103151139.29690-1-pali@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | cpufreq: Add missing modalias for tristate drivers | expand |
On Tue, Nov 3, 2020 at 4:14 PM Pali Rohár <pali@kernel.org> wrote: > > Some of cpufreq drivers are tristate, can be compiled as modules, but do > not have defined modalias for automatic loading. This patch series add > for all those cpufreq drivers missing MODULE_DEVICE_TABLE macro, based > on OF definitions, or MODULE_ALIAS for platform drivers. > > MODULE_DEVICE_TABLE is not explictily added only for speedstep-centrino, > speedstep-ich and speedstep-smi drivers as it was removed in commit > b11d77fa300d9 ("cpufreq: Convert to new X86 CPU match macros"). > > Pali Rohár (9): > cpufreq: ap806: Add missing MODULE_DEVICE_TABLE > cpufreq: highbank: Add missing MODULE_DEVICE_TABLE > cpufreq: mediatek: Add missing MODULE_DEVICE_TABLE > cpufreq: qcom: Add missing MODULE_DEVICE_TABLE > cpufreq: st: Add missing MODULE_DEVICE_TABLE > cpufreq: sun50i: Add missing MODULE_DEVICE_TABLE > cpufreq: loongson1: Add missing MODULE_ALIAS > cpufreq: scpi: Add missing MODULE_ALIAS > cpufreq: vexpress-spc: Add missing MODULE_ALIAS > > drivers/cpufreq/armada-8k-cpufreq.c | 6 ++++++ > drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ > drivers/cpufreq/loongson1-cpufreq.c | 1 + > drivers/cpufreq/mediatek-cpufreq.c | 1 + > drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 + > drivers/cpufreq/scpi-cpufreq.c | 1 + > drivers/cpufreq/sti-cpufreq.c | 7 +++++++ > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + > drivers/cpufreq/vexpress-spc-cpufreq.c | 1 + > 9 files changed, 26 insertions(+) > > -- Viresh, any comments?
On 09-11-20, 15:18, Rafael J. Wysocki wrote: > On Tue, Nov 3, 2020 at 4:14 PM Pali Rohár <pali@kernel.org> wrote: > > > > Some of cpufreq drivers are tristate, can be compiled as modules, but do > > not have defined modalias for automatic loading. This patch series add > > for all those cpufreq drivers missing MODULE_DEVICE_TABLE macro, based > > on OF definitions, or MODULE_ALIAS for platform drivers. > > > > MODULE_DEVICE_TABLE is not explictily added only for speedstep-centrino, > > speedstep-ich and speedstep-smi drivers as it was removed in commit > > b11d77fa300d9 ("cpufreq: Convert to new X86 CPU match macros"). > > > > Pali Rohár (9): > > cpufreq: ap806: Add missing MODULE_DEVICE_TABLE > > cpufreq: highbank: Add missing MODULE_DEVICE_TABLE > > cpufreq: mediatek: Add missing MODULE_DEVICE_TABLE > > cpufreq: qcom: Add missing MODULE_DEVICE_TABLE > > cpufreq: st: Add missing MODULE_DEVICE_TABLE > > cpufreq: sun50i: Add missing MODULE_DEVICE_TABLE > > cpufreq: loongson1: Add missing MODULE_ALIAS > > cpufreq: scpi: Add missing MODULE_ALIAS > > cpufreq: vexpress-spc: Add missing MODULE_ALIAS > > > > drivers/cpufreq/armada-8k-cpufreq.c | 6 ++++++ > > drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ > > drivers/cpufreq/loongson1-cpufreq.c | 1 + > > drivers/cpufreq/mediatek-cpufreq.c | 1 + > > drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 + > > drivers/cpufreq/scpi-cpufreq.c | 1 + > > drivers/cpufreq/sti-cpufreq.c | 7 +++++++ > > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + > > drivers/cpufreq/vexpress-spc-cpufreq.c | 1 + > > 9 files changed, 26 insertions(+) > > > > -- > > Viresh, any comments? I found the patches to be fine and marked it to be applied soon in mutt. I was waiting for the maintainers of the drivers to respond, after that I would have applied it for 5.11.
On Tue, Nov 10, 2020 at 3:35 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > On 09-11-20, 15:18, Rafael J. Wysocki wrote: > > On Tue, Nov 3, 2020 at 4:14 PM Pali Rohár <pali@kernel.org> wrote: > > > > > > Some of cpufreq drivers are tristate, can be compiled as modules, but do > > > not have defined modalias for automatic loading. This patch series add > > > for all those cpufreq drivers missing MODULE_DEVICE_TABLE macro, based > > > on OF definitions, or MODULE_ALIAS for platform drivers. > > > > > > MODULE_DEVICE_TABLE is not explictily added only for speedstep-centrino, > > > speedstep-ich and speedstep-smi drivers as it was removed in commit > > > b11d77fa300d9 ("cpufreq: Convert to new X86 CPU match macros"). > > > > > > Pali Rohár (9): > > > cpufreq: ap806: Add missing MODULE_DEVICE_TABLE > > > cpufreq: highbank: Add missing MODULE_DEVICE_TABLE > > > cpufreq: mediatek: Add missing MODULE_DEVICE_TABLE > > > cpufreq: qcom: Add missing MODULE_DEVICE_TABLE > > > cpufreq: st: Add missing MODULE_DEVICE_TABLE > > > cpufreq: sun50i: Add missing MODULE_DEVICE_TABLE > > > cpufreq: loongson1: Add missing MODULE_ALIAS > > > cpufreq: scpi: Add missing MODULE_ALIAS > > > cpufreq: vexpress-spc: Add missing MODULE_ALIAS > > > > > > drivers/cpufreq/armada-8k-cpufreq.c | 6 ++++++ > > > drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ > > > drivers/cpufreq/loongson1-cpufreq.c | 1 + > > > drivers/cpufreq/mediatek-cpufreq.c | 1 + > > > drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 + > > > drivers/cpufreq/scpi-cpufreq.c | 1 + > > > drivers/cpufreq/sti-cpufreq.c | 7 +++++++ > > > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + > > > drivers/cpufreq/vexpress-spc-cpufreq.c | 1 + > > > 9 files changed, 26 insertions(+) > > > > > > -- > > > > Viresh, any comments? > > I found the patches to be fine and marked it to be applied soon in mutt. I was > waiting for the maintainers of the drivers to respond, after that I would have > applied it for 5.11. OK, so please take all of them then (some of them are not ARM-related AFAICS).
On 03-11-20, 16:11, Pali Rohár wrote: > Some of cpufreq drivers are tristate, can be compiled as modules, but do > not have defined modalias for automatic loading. This patch series add > for all those cpufreq drivers missing MODULE_DEVICE_TABLE macro, based > on OF definitions, or MODULE_ALIAS for platform drivers. > > MODULE_DEVICE_TABLE is not explictily added only for speedstep-centrino, > speedstep-ich and speedstep-smi drivers as it was removed in commit > b11d77fa300d9 ("cpufreq: Convert to new X86 CPU match macros"). > > Pali Rohár (9): > cpufreq: ap806: Add missing MODULE_DEVICE_TABLE > cpufreq: highbank: Add missing MODULE_DEVICE_TABLE > cpufreq: mediatek: Add missing MODULE_DEVICE_TABLE > cpufreq: qcom: Add missing MODULE_DEVICE_TABLE > cpufreq: st: Add missing MODULE_DEVICE_TABLE > cpufreq: sun50i: Add missing MODULE_DEVICE_TABLE > cpufreq: loongson1: Add missing MODULE_ALIAS > cpufreq: scpi: Add missing MODULE_ALIAS > cpufreq: vexpress-spc: Add missing MODULE_ALIAS > > drivers/cpufreq/armada-8k-cpufreq.c | 6 ++++++ > drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ > drivers/cpufreq/loongson1-cpufreq.c | 1 + > drivers/cpufreq/mediatek-cpufreq.c | 1 + > drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 + > drivers/cpufreq/scpi-cpufreq.c | 1 + > drivers/cpufreq/sti-cpufreq.c | 7 +++++++ > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + > drivers/cpufreq/vexpress-spc-cpufreq.c | 1 + > 9 files changed, 26 insertions(+) Applied. Thanks.
Some of cpufreq drivers are tristate, can be compiled as modules, but do not have defined modalias for automatic loading. This patch series add for all those cpufreq drivers missing MODULE_DEVICE_TABLE macro, based on OF definitions, or MODULE_ALIAS for platform drivers. MODULE_DEVICE_TABLE is not explictily added only for speedstep-centrino, speedstep-ich and speedstep-smi drivers as it was removed in commit b11d77fa300d9 ("cpufreq: Convert to new X86 CPU match macros"). Pali Rohár (9): cpufreq: ap806: Add missing MODULE_DEVICE_TABLE cpufreq: highbank: Add missing MODULE_DEVICE_TABLE cpufreq: mediatek: Add missing MODULE_DEVICE_TABLE cpufreq: qcom: Add missing MODULE_DEVICE_TABLE cpufreq: st: Add missing MODULE_DEVICE_TABLE cpufreq: sun50i: Add missing MODULE_DEVICE_TABLE cpufreq: loongson1: Add missing MODULE_ALIAS cpufreq: scpi: Add missing MODULE_ALIAS cpufreq: vexpress-spc: Add missing MODULE_ALIAS drivers/cpufreq/armada-8k-cpufreq.c | 6 ++++++ drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ drivers/cpufreq/loongson1-cpufreq.c | 1 + drivers/cpufreq/mediatek-cpufreq.c | 1 + drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 + drivers/cpufreq/scpi-cpufreq.c | 1 + drivers/cpufreq/sti-cpufreq.c | 7 +++++++ drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + drivers/cpufreq/vexpress-spc-cpufreq.c | 1 + 9 files changed, 26 insertions(+)