[PATCHv2,0/2] selftests: pmtu.sh: improve the test result processing

Message

Po-Hsu Lin Nov. 10, 2020, 2 a.m. UTC

The pmtu.sh test script treats all non-zero return code as a failure,
thus it will be marked as FAILED when some sub-test got skipped.

This patchset will:
  1. Use the kselftest framework skip code $ksft_skip to replace the
     hardcoded SKIP return code.
  2. Improve the result processing, the test will be marked as PASSED
     if nothing goes wrong and not all the tests were skipped.

Po-Hsu Lin (2):
  selftests: pmtu.sh: use $ksft_skip for skipped return code
  selftests: pmtu.sh: improve the test result processing

 tools/testing/selftests/net/pmtu.sh | 79 +++++++++++++++++++++----------------
 1 file changed, 46 insertions(+), 33 deletions(-)

Comments

Jakub Kicinski Nov. 12, 2020, 3:58 p.m. UTC | #1

On Tue, 10 Nov 2020 10:00:47 +0800 Po-Hsu Lin wrote:
> The pmtu.sh test script treats all non-zero return code as a failure,
> thus it will be marked as FAILED when some sub-test got skipped.
> 
> This patchset will:
>   1. Use the kselftest framework skip code $ksft_skip to replace the
>      hardcoded SKIP return code.
>   2. Improve the result processing, the test will be marked as PASSED
>      if nothing goes wrong and not all the tests were skipped.

Applied, thank you!