[net,0/4,pull,request] Intel Wired LAN Driver Updates 2020-11-10

Message

Tony Nguyen Nov. 11, 2020, 12:19 a.m. UTC

This series contains updates to i40e and igc drivers and the MAINTAINERS
file.

Slawomir fixes updating VF MAC addresses to fix various issues related
to reporting and setting of these addresses for i40e.

Dan Carpenter fixes a possible used before being initialized issue for
i40e.

Vinicius fixes reporting of netdev stats for igc.

Tony updates repositories for Intel Ethernet Drivers.

The following are changes since commit 989ef49bdf100cc772b3a8737089df36b1ab1e30:
  mptcp: provide rmem[0] limit
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue 40GbE

Dan Carpenter (1):
  i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()

Slawomir Laba (1):
  i40e: Fix MAC address setting for a VF via Host/VM

Tony Nguyen (1):
  MAINTAINERS: Update repositories for Intel Ethernet Drivers

Vinicius Costa Gomes (1):
  igc: Fix returning wrong statistics

 MAINTAINERS                                   |  4 +--
 .../ethernet/intel/i40e/i40e_virtchnl_pf.c    | 26 +++++++++++++++++--
 drivers/net/ethernet/intel/i40e/i40e_xsk.c    |  2 +-
 drivers/net/ethernet/intel/igc/igc_main.c     | 14 +++++-----
 4 files changed, 35 insertions(+), 11 deletions(-)

Comments

Jakub Kicinski Nov. 12, 2020, 4:55 p.m. UTC | #1

On Tue, 10 Nov 2020 16:19:51 -0800 Tony Nguyen wrote:
> This series contains updates to i40e and igc drivers and the MAINTAINERS
> file.
> 
> Slawomir fixes updating VF MAC addresses to fix various issues related
> to reporting and setting of these addresses for i40e.
> 
> Dan Carpenter fixes a possible used before being initialized issue for
> i40e.
> 
> Vinicius fixes reporting of netdev stats for igc.
> 
> Tony updates repositories for Intel Ethernet Drivers.

Pulled, thanks!

Please double check the use of the spin lock in patch 3. Stats are
updated in an atomic context when read from /proc, you probably need 
to convert that spin lock to _bh.

Tony Nguyen Nov. 12, 2020, 7:18 p.m. UTC | #2

On Thu, 2020-11-12 at 08:55 -0800, Jakub Kicinski wrote:
> On Tue, 10 Nov 2020 16:19:51 -0800 Tony Nguyen wrote:
> > This series contains updates to i40e and igc drivers and the
> > MAINTAINERS
> > file.
> > 
> > Slawomir fixes updating VF MAC addresses to fix various issues
> > related
> > to reporting and setting of these addresses for i40e.
> > 
> > Dan Carpenter fixes a possible used before being initialized issue
> > for
> > i40e.
> > 
> > Vinicius fixes reporting of netdev stats for igc.
> > 
> > Tony updates repositories for Intel Ethernet Drivers.
> 
> Pulled, thanks!
> 
> Please double check the use of the spin lock in patch 3. Stats are
> updated in an atomic context when read from /proc, you probably need 
> to convert that spin lock to _bh.

Thanks Jakub. I'll look into it.

Vinicius Costa Gomes Nov. 12, 2020, 7:55 p.m. UTC | #3

Jakub Kicinski <[e-mail]> writes:
>
> Pulled, thanks!
>
> Please double check the use of the spin lock in patch 3. Stats are
> updated in an atomic context when read from /proc, you probably need 
> to convert that spin lock to _bh.

I just did some tests with lockdep enabled, reading from /proc/net/dev
in a loop, and everything seems fine. Am I missing something?


Cheers,

Jakub Kicinski Nov. 12, 2020, 8:01 p.m. UTC | #4

On Thu, 12 Nov 2020 11:55:24 -0800 Vinicius Costa Gomes wrote:
> Jakub Kicinski <[e-mail]> writes:
> >
> > Pulled, thanks!
> >
> > Please double check the use of the spin lock in patch 3. Stats are
> > updated in an atomic context when read from /proc, you probably need 
> > to convert that spin lock to _bh.  
> 
> I just did some tests with lockdep enabled, reading from /proc/net/dev
> in a loop, and everything seems fine. Am I missing something?

Indeed /proc only takes the RCU lock so you should be fine, thanks
for checking.