| Message ID | 20201112110204.2083435-3-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | f1556986babffb0dd75970cd7a0563e3e1ee387a |
| Headers | show |
| Series | Rid W=1 issues from Input | expand |
On Thu, Nov 12, 2020 at 11:01:51AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/input/keyboard/samsung-keypad.c: In function ‘samsung_keypad_irq’: > drivers/input/keyboard/samsung-keypad.c:149:15: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Joonyoung Shim <jy0922.shim@samsung.com> > Cc: Donghwa Lee <dh09.lee@samsung.com> > Cc: linux-input@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied, thank you.
diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c index 70c1d086bdd2a..1ed939d9798cf 100644 --- a/drivers/input/keyboard/samsung-keypad.c +++ b/drivers/input/keyboard/samsung-keypad.c @@ -146,13 +146,12 @@ static irqreturn_t samsung_keypad_irq(int irq, void *dev_id) { struct samsung_keypad *keypad = dev_id; unsigned int row_state[SAMSUNG_MAX_COLS]; - unsigned int val; bool key_down; pm_runtime_get_sync(&keypad->pdev->dev); do { - val = readl(keypad->base + SAMSUNG_KEYIFSTSCLR); + readl(keypad->base + SAMSUNG_KEYIFSTSCLR); /* Clear interrupt. */ writel(~0x0, keypad->base + SAMSUNG_KEYIFSTSCLR);
Fixes the following W=1 kernel build warning(s): drivers/input/keyboard/samsung-keypad.c: In function ‘samsung_keypad_irq’: drivers/input/keyboard/samsung-keypad.c:149:15: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Joonyoung Shim <jy0922.shim@samsung.com> Cc: Donghwa Lee <dh09.lee@samsung.com> Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/input/keyboard/samsung-keypad.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)