| Message ID | 160530304068.15651.18355773009751195447.stgit@sifl (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Fri, 13 Nov 2020, Paul Moore wrote: > Static checking revealed that a previous fix to > netlbl_unlabel_staticlist() leaves a stack variable uninitialized, > this patches fixes that. > > Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()") > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Paul Moore <paul@paul-moore.com> Reviewed-by: James Morris <jamorris@linux.microsoft.com> > --- > net/netlabel/netlabel_unlabeled.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netlabel_unlabeled.c > index fc55c9116da0..ccb491642811 100644 > --- a/net/netlabel/netlabel_unlabeled.c > +++ b/net/netlabel/netlabel_unlabeled.c > @@ -1167,7 +1167,7 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb, > u32 skip_bkt = cb->args[0]; > u32 skip_chain = cb->args[1]; > u32 skip_addr4 = cb->args[2]; > - u32 iter_bkt, iter_chain, iter_addr4 = 0, iter_addr6 = 0; > + u32 iter_bkt, iter_chain = 0, iter_addr4 = 0, iter_addr6 = 0; > struct netlbl_unlhsh_iface *iface; > struct list_head *iter_list; > struct netlbl_af4list *addr4; >
On Sat, 14 Nov 2020 18:03:56 +1100 (AEDT) James Morris wrote: > > Static checking revealed that a previous fix to > > netlbl_unlabel_staticlist() leaves a stack variable uninitialized, > > this patches fixes that. > > > > Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()") > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > > Signed-off-by: Paul Moore <paul@paul-moore.com> > > Reviewed-by: James Morris <jamorris@linux.microsoft.com> Applied, thanks!
diff --git a/net/netlabel/netlabel_unlabeled.c b/net/netlabel/netlabel_unlabeled.c index fc55c9116da0..ccb491642811 100644 --- a/net/netlabel/netlabel_unlabeled.c +++ b/net/netlabel/netlabel_unlabeled.c @@ -1167,7 +1167,7 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb, u32 skip_bkt = cb->args[0]; u32 skip_chain = cb->args[1]; u32 skip_addr4 = cb->args[2]; - u32 iter_bkt, iter_chain, iter_addr4 = 0, iter_addr6 = 0; + u32 iter_bkt, iter_chain = 0, iter_addr4 = 0, iter_addr6 = 0; struct netlbl_unlhsh_iface *iface; struct list_head *iter_list; struct netlbl_af4list *addr4;
Static checking revealed that a previous fix to netlbl_unlabel_staticlist() leaves a stack variable uninitialized, this patches fixes that. Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Paul Moore <paul@paul-moore.com> --- net/netlabel/netlabel_unlabeled.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)