| Message ID | 20201112161920.2671430-5-caleb@connolly.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] drm/panel/samsung-sofef00: Add panel for OnePlus 6/T devices | expand |
On Thu, 12 Nov 2020 16:21:54 +0000, Caleb Connolly wrote: > Used by the OnePlus 6/T device trees > > Signed-off-by: Caleb Connolly <caleb@connolly.tech> > --- > .../bindings/arm/oneplus/oneplus-boards.yaml | 25 +++++++++++++++++++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 2 files changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml: 'additionalProperties' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml See https://patchwork.ozlabs.org/patch/1399086 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Thu, Nov 12, 2020 at 04:21:54PM +0000, Caleb Connolly wrote: > Used by the OnePlus 6/T device trees > > Signed-off-by: Caleb Connolly <caleb@connolly.tech> > --- > .../bindings/arm/oneplus/oneplus-boards.yaml | 25 +++++++++++++++++++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 2 files changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml > > diff --git a/Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml b/Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml > new file mode 100644 > index 000000000000..a4d9bbd5681f > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml > @@ -0,0 +1,25 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/oneplus/oneplus-boards.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: OnePlus based boards > + > +maintainers: > + - Caleb Connolly <caleb@connolly.tech> > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - description: SDM845 based boards There should be a sdm845 fallback compatible. Also, board level compatibles are documented in a per SoC family schema (qcom.yaml) which should already define the fallback. > + items: > + - enum: > + - oneplus,enchilada # OnePlus 6 > + - oneplus,fajita # OnePlus 6T > + - const: oneplus,oneplus6 # OnePlus 6 and derivatives With a SoC fallback, having this as a 3rd compatible probably isn't too useful. 3 levels of compatible is mainly done when there's a SoM plus baseboard. > + > +required: > + - compatible > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 2735be1a8470..372c1136081e 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -768,6 +768,8 @@ patternProperties: > description: OLIMEX Ltd. > "^olpc,.*": > description: One Laptop Per Child > + "^oneplus,.*": > + description: One Plus Technology (Shenzhen) Co., Ltd. > "^onion,.*": > description: Onion Corporation > "^onnn,.*": > -- > 2.29.2 > >
diff --git a/Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml b/Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml new file mode 100644 index 000000000000..a4d9bbd5681f --- /dev/null +++ b/Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml @@ -0,0 +1,25 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/oneplus/oneplus-boards.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OnePlus based boards + +maintainers: + - Caleb Connolly <caleb@connolly.tech> + +properties: + $nodename: + const: '/' + compatible: + oneOf: + - description: SDM845 based boards + items: + - enum: + - oneplus,enchilada # OnePlus 6 + - oneplus,fajita # OnePlus 6T + - const: oneplus,oneplus6 # OnePlus 6 and derivatives + +required: + - compatible diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 2735be1a8470..372c1136081e 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -768,6 +768,8 @@ patternProperties: description: OLIMEX Ltd. "^olpc,.*": description: One Laptop Per Child + "^oneplus,.*": + description: One Plus Technology (Shenzhen) Co., Ltd. "^onion,.*": description: Onion Corporation "^onnn,.*":
Used by the OnePlus 6/T device trees Signed-off-by: Caleb Connolly <caleb@connolly.tech> --- .../bindings/arm/oneplus/oneplus-boards.yaml | 25 +++++++++++++++++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 ++ 2 files changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/oneplus/oneplus-boards.yaml