diff mbox series

scsi: ufs: show lba and length for unmap commands

Message ID 20201112165950.518952-1-jaegeuk@kernel.org (mailing list archive)
State Changes Requested
Headers show
Series scsi: ufs: show lba and length for unmap commands | expand

Commit Message

Jaegeuk Kim Nov. 12, 2020, 4:59 p.m. UTC 
From: Leo Liou <leoliou@google.com>

We have lba and length for unmap commands.

Signed-off-by: Leo Liou <leoliou@google.com>
---
 drivers/scsi/ufs/ufshcd.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Stanley Chu Nov. 13, 2020, 1:10 a.m. UTC | #1 
Hi,

On Thu, 2020-11-12 at 08:59 -0800, Jaegeuk Kim wrote:
> From: Leo Liou <leoliou@google.com>
> 
> We have lba and length for unmap commands.
> 
> Signed-off-by: Leo Liou <leoliou@google.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 86c8dee01ca9..dba3ee307307 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -376,6 +376,11 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba,
>  				lrbp->ucd_req_ptr->sc.exp_data_transfer_len);
>  			if (opcode == WRITE_10)
>  				group_id = lrbp->cmd->cmnd[6];
> +		} else if (opcode == UNMAP) {
> +			if (cmd->request) {
> +				lba = scsi_get_lba(cmd);
> +				transfer_len = blk_rq_bytes(cmd->request);
> +			}

Nitpicking: Perhaps we could unify the method of obtaining both lba and
transfer_len for all READ/WRITE/UNMAP commands?

Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>

>  		}
>  	}
>
Martin K. Petersen Nov. 17, 2020, 3:40 a.m. UTC | #2 
Hi Jaegeuk!

> From: Leo Liou <leoliou@google.com>
>
> We have lba and length for unmap commands.
>
> Signed-off-by: Leo Liou <leoliou@google.com>

Doesn't apply to 5.11/scsi-queue.

Also needs a Signed-off-by: tag from you.

Thanks!
Jaegeuk Kim Nov. 17, 2020, 5:04 p.m. UTC | #3 
On 11/16, Martin K. Petersen wrote:
> 
> Hi Jaegeuk!
> 
> > From: Leo Liou <leoliou@google.com>
> >
> > We have lba and length for unmap commands.
> >
> > Signed-off-by: Leo Liou <leoliou@google.com>
> 
> Doesn't apply to 5.11/scsi-queue.
> 
> Also needs a Signed-off-by: tag from you.

Hi Martin,

Could you please consider this patch series?

https://lore.kernel.org/linux-scsi/20201117165839.1643377-1-jaegeuk@kernel.org/

Thanks,

> 
> Thanks!
> 
> -- 
> Martin K. Petersen	Oracle Linux Engineering
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 86c8dee01ca9..dba3ee307307 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -376,6 +376,11 @@  static void ufshcd_add_command_trace(struct ufs_hba *hba,
 				lrbp->ucd_req_ptr->sc.exp_data_transfer_len);
 			if (opcode == WRITE_10)
 				group_id = lrbp->cmd->cmnd[6];
+		} else if (opcode == UNMAP) {
+			if (cmd->request) {
+				lba = scsi_get_lba(cmd);
+				transfer_len = blk_rq_bytes(cmd->request);
+			}
 		}
 	}