mbox series

[net-next,0/2] enetc: Clean endianness warnings up

Message ID 20201117182004.27389-1-claudiu.manoil@nxp.com (mailing list archive)
Headers show
Series enetc: Clean endianness warnings up | expand

Message

Claudiu Manoil Nov. 17, 2020, 6:20 p.m. UTC 
Cleanup patches to address the outstanding endianness issues
in the driver reported by sparse.

Claudiu Manoil (2):
  enetc: Fix endianness issues for enetc_ethtool
  enetc: Fix endianness issues for enetc_qos

 .../net/ethernet/freescale/enetc/enetc_hw.h   |  8 +-
 .../net/ethernet/freescale/enetc/enetc_qos.c  | 84 +++++++++----------
 2 files changed, 43 insertions(+), 49 deletions(-)

Comments

Jakub Kicinski Nov. 18, 2020, 5:52 p.m. UTC | #1 
On Tue, 17 Nov 2020 20:20:02 +0200 Claudiu Manoil wrote:
> Cleanup patches to address the outstanding endianness issues
> in the driver reported by sparse.

Build bot says this doesn't apply to net-next, could you double check?
Jakub Kicinski Nov. 18, 2020, 5:54 p.m. UTC | #2 
On Wed, 18 Nov 2020 09:52:58 -0800 Jakub Kicinski wrote:
> On Tue, 17 Nov 2020 20:20:02 +0200 Claudiu Manoil wrote:
> > Cleanup patches to address the outstanding endianness issues
> > in the driver reported by sparse.  
> 
> Build bot says this doesn't apply to net-next, could you double check?

Hm, not sure what happened there, it does seem to apply now.

Could you resend regardless? Would be good to get this build tested.
Claudiu Manoil Nov. 19, 2020, 10:18 a.m. UTC | #3 
>-----Original Message-----
>From: Jakub Kicinski <kuba@kernel.org>
[...]
>Subject: Re: [PATCH net-next 0/2] enetc: Clean endianness warnings up
>
>On Wed, 18 Nov 2020 09:52:58 -0800 Jakub Kicinski wrote:
>> On Tue, 17 Nov 2020 20:20:02 +0200 Claudiu Manoil wrote:
>> > Cleanup patches to address the outstanding endianness issues
>> > in the driver reported by sparse.
>>
>> Build bot says this doesn't apply to net-next, could you double check?
>
>Hm, not sure what happened there, it does seem to apply now.
>
>Could you resend regardless? Would be good to get this build tested.

Reformatted and resent patches.
Jakub Kicinski Nov. 25, 2020, 10:55 p.m. UTC | #4 
On Wed, 18 Nov 2020 09:54:35 -0800 Jakub Kicinski wrote:
> On Wed, 18 Nov 2020 09:52:58 -0800 Jakub Kicinski wrote:
> > On Tue, 17 Nov 2020 20:20:02 +0200 Claudiu Manoil wrote:  
> > > Cleanup patches to address the outstanding endianness issues
> > > in the driver reported by sparse.    
> > 
> > Build bot says this doesn't apply to net-next, could you double check?  
> 
> Hm, not sure what happened there, it does seem to apply now.

Ah, I figured it out now. Apparently Patchwork orders the patches by
date / its own patch ID (assigned at arrival time).

When mbox for the series is downloaded things work correctly, but build
bot tries to fetch patches one by one, and there if patches arrived at
the mailing list out of order - they don't apply.

This wasn't as evident here with just two patches seemingly in the
right order but Randy just posted a 10 patch series which has the same
issue.

I reported it upstream [1] and tried to work around it in the bot.

Fingers crossed.

[1] https://github.com/getpatchwork/patchwork/issues/386