diff mbox series

scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO

Message ID 20201114004754.235378-1-ebiggers@kernel.org (mailing list archive)
State Accepted
Commit 6ac63216a7af03e8281758d7cd32a09718531eb2
Headers show
Series scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO | expand

Commit Message

Eric Biggers Nov. 14, 2020, 12:47 a.m. UTC 
From: Eric Biggers <ebiggers@google.com>

QCOM_SCM is only needed to make the qcom_scm_*() calls in
ufs-qcom-ice.c, which is only compiled when SCSI_UFS_CRYPTO=y.  So don't
unnecessarily enable QCOM_SCM when SCSI_UFS_CRYPTO=n.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 drivers/scsi/ufs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Nov. 17, 2020, 4:37 a.m. UTC | #1 
Eric,

> QCOM_SCM is only needed to make the qcom_scm_*() calls in
> ufs-qcom-ice.c, which is only compiled when SCSI_UFS_CRYPTO=y.  So
> don't unnecessarily enable QCOM_SCM when SCSI_UFS_CRYPTO=n.

Applied to 5.11/scsi-staging, thanks!
Martin K. Petersen Nov. 20, 2020, 3:29 a.m. UTC | #2 
On Fri, 13 Nov 2020 16:47:54 -0800, Eric Biggers wrote:

> QCOM_SCM is only needed to make the qcom_scm_*() calls in
> ufs-qcom-ice.c, which is only compiled when SCSI_UFS_CRYPTO=y.  So don't
> unnecessarily enable QCOM_SCM when SCSI_UFS_CRYPTO=n.

Applied to 5.11/scsi-queue, thanks!

[1/1] scsi: ufs-qcom: Only select QCOM_SCM if SCSI_UFS_CRYPTO
      https://git.kernel.org/mkp/scsi/c/6ac63216a7af
patchwork-bot+linux-arm-msm@kernel.org Dec. 29, 2020, 8:15 p.m. UTC | #3 
Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Fri, 13 Nov 2020 16:47:54 -0800 you wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> QCOM_SCM is only needed to make the qcom_scm_*() calls in
> ufs-qcom-ice.c, which is only compiled when SCSI_UFS_CRYPTO=y.  So don't
> unnecessarily enable QCOM_SCM when SCSI_UFS_CRYPTO=n.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> 
> [...]

Here is the summary with links:
  - scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO
    https://git.kernel.org/qcom/c/6ac63216a7af

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index dcdb4eb1f90ba..3f6dfed4fe84b 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -99,7 +99,7 @@  config SCSI_UFS_DWC_TC_PLATFORM
 config SCSI_UFS_QCOM
 	tristate "QCOM specific hooks to UFS controller platform driver"
 	depends on SCSI_UFSHCD_PLATFORM && ARCH_QCOM
-	select QCOM_SCM
+	select QCOM_SCM if SCSI_UFS_CRYPTO
 	select RESET_CONTROLLER
 	help
 	  This selects the QCOM specific additions to UFSHCD platform driver.