| Message ID | 20201116024810.2415819-7-kuhn.chenqun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | silence the compiler warnings | expand |
David, can you queue this patch for 5.2 (bugfix)? On 11/16/20 3:48 AM, Chen Qun wrote: > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’: > hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > 118 | if (level) { > | ^ > hw/ppc/ppc.c:123:9: note: here > 123 | case PPC6xx_INPUT_INT: > | ^~~~ > > According to the discussion, a break statement needs to be added here. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > Reviewed-by: Thomas Huth <thuth@redhat.com> > Acked-by: David Gibson <david@gibson.dropbear.id.au> > --- > v1->v2: Add a "break" statement here instead of /* fall through */ comments > (Base on Thomas's and David review). > > Cc: Thomas Huth <thuth@redhat.com> > Cc: David Gibson <david@gibson.dropbear.id.au> > --- > hw/ppc/ppc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c > index 4a11fb1640..1b98272076 100644 > --- a/hw/ppc/ppc.c > +++ b/hw/ppc/ppc.c > @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int level) > } else { > cpu_ppc_tb_stop(env); > } > + break; > case PPC6xx_INPUT_INT: > /* Level sensitive - active high */ > LOG_IRQ("%s: set the external IRQ state to %d\n", >
On Mon, Nov 16, 2020 at 12:46:32PM +0100, Philippe Mathieu-Daudé wrote: > David, can you queue this patch for 5.2 (bugfix)? Sorry about this, I've been on vacation. Although it is a bugfix, it's been there for a very long time and no-one's hit it in practice. So, I'm disinclined to push it in this late in the 5.2 cycle. > > On 11/16/20 3:48 AM, Chen Qun wrote: > > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > > hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’: > > hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > > 118 | if (level) { > > | ^ > > hw/ppc/ppc.c:123:9: note: here > > 123 | case PPC6xx_INPUT_INT: > > | ^~~~ > > > > According to the discussion, a break statement needs to be added here. > > > > Reported-by: Euler Robot <euler.robot@huawei.com> > > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > > Reviewed-by: Thomas Huth <thuth@redhat.com> > > Acked-by: David Gibson <david@gibson.dropbear.id.au> > > --- > > v1->v2: Add a "break" statement here instead of /* fall through */ comments > > (Base on Thomas's and David review). > > > > Cc: Thomas Huth <thuth@redhat.com> > > Cc: David Gibson <david@gibson.dropbear.id.au> > > --- > > hw/ppc/ppc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c > > index 4a11fb1640..1b98272076 100644 > > --- a/hw/ppc/ppc.c > > +++ b/hw/ppc/ppc.c > > @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int level) > > } else { > > cpu_ppc_tb_stop(env); > > } > > + break; > > case PPC6xx_INPUT_INT: > > /* Level sensitive - active high */ > > LOG_IRQ("%s: set the external IRQ state to %d\n", > > >
On Mon, Nov 16, 2020 at 10:48:09AM +0800, Chen Qun wrote: > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’: > hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > 118 | if (level) { > | ^ > hw/ppc/ppc.c:123:9: note: here > 123 | case PPC6xx_INPUT_INT: > | ^~~~ > > According to the discussion, a break statement needs to be added here. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > Reviewed-by: Thomas Huth <thuth@redhat.com> > Acked-by: David Gibson <david@gibson.dropbear.id.au> Applied to ppc-for-6.0, thanks. > --- > v1->v2: Add a "break" statement here instead of /* fall through */ comments > (Base on Thomas's and David review). > > Cc: Thomas Huth <thuth@redhat.com> > Cc: David Gibson <david@gibson.dropbear.id.au> > --- > hw/ppc/ppc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c > index 4a11fb1640..1b98272076 100644 > --- a/hw/ppc/ppc.c > +++ b/hw/ppc/ppc.c > @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int level) > } else { > cpu_ppc_tb_stop(env); > } > + break; > case PPC6xx_INPUT_INT: > /* Level sensitive - active high */ > LOG_IRQ("%s: set the external IRQ state to %d\n",
diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 4a11fb1640..1b98272076 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int level) } else { cpu_ppc_tb_stop(env); } + break; case PPC6xx_INPUT_INT: /* Level sensitive - active high */ LOG_IRQ("%s: set the external IRQ state to %d\n",
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’: hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-fallthrough=] 118 | if (level) { | ^ hw/ppc/ppc.c:123:9: note: here 123 | case PPC6xx_INPUT_INT: | ^~~~ According to the discussion, a break statement needs to be added here. Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> --- v1->v2: Add a "break" statement here instead of /* fall through */ comments (Base on Thomas's and David review). Cc: Thomas Huth <thuth@redhat.com> Cc: David Gibson <david@gibson.dropbear.id.au> --- hw/ppc/ppc.c | 1 + 1 file changed, 1 insertion(+)