| Message ID | 1e081610a68043fe89ca5a2795963cbee6d5fc0f.1605896059.git.gustavoars@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Fix fall-through warnings for Clang | expand |
On Fri, Nov 20, 2020 at 7:34 PM Gustavo A. R. Silva <gustavoars@kernel.org> wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/acpi/sbshc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/sbshc.c b/drivers/acpi/sbshc.c > index 53c2862c4c75..0b3de0e63633 100644 > --- a/drivers/acpi/sbshc.c > +++ b/drivers/acpi/sbshc.c > @@ -231,6 +231,7 @@ static int smbus_alarm(void *context) > case ACPI_SBS_BATTERY: > acpi_os_execute(OSL_NOTIFY_HANDLER, > acpi_smbus_callback, hc); > + break; > default:; Why don't you simply drop the default case below (it's empty anyway)? > } > mutex_unlock(&hc->lock); > -- > 2.27.0 >
diff --git a/drivers/acpi/sbshc.c b/drivers/acpi/sbshc.c index 53c2862c4c75..0b3de0e63633 100644 --- a/drivers/acpi/sbshc.c +++ b/drivers/acpi/sbshc.c @@ -231,6 +231,7 @@ static int smbus_alarm(void *context) case ACPI_SBS_BATTERY: acpi_os_execute(OSL_NOTIFY_HANDLER, acpi_smbus_callback, hc); + break; default:; } mutex_unlock(&hc->lock);
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/acpi/sbshc.c | 1 + 1 file changed, 1 insertion(+)