| Message ID | 20201122234253.34047-1-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | a35c6e18abae71c1321a9d1d16d975bd7de65273 |
| Headers | show |
| Series | slimbus: qcom-ngd-ctrl: Constify static structs | expand |
On 22/11/2020 23:42, Rikard Falkeborn wrote: > qcom_slim_qmi_msg_handlers[] and qcom_slim_ngd_qmi_svc_event_ops are > only used as input arguments to qmi_handle_init() which accepts const > pointers to both qmi_ops and qmi_msg_handler. Make them const to allow > the compiler to put them in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> > --- Applied thanks, --srini
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Mon, 23 Nov 2020 00:42:53 +0100 you wrote: > qcom_slim_qmi_msg_handlers[] and qcom_slim_ngd_qmi_svc_event_ops are > only used as input arguments to qmi_handle_init() which accepts const > pointers to both qmi_ops and qmi_msg_handler. Make them const to allow > the compiler to put them in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> > > [...] Here is the summary with links: - slimbus: qcom-ngd-ctrl: Constify static structs https://git.kernel.org/qcom/c/a35c6e18abae You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index d8decb345e9d..ea8f605b5c99 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -434,7 +434,7 @@ static int qcom_slim_qmi_send_power_request(struct qcom_slim_ngd_ctrl *ctrl, return 0; } -static struct qmi_msg_handler qcom_slim_qmi_msg_handlers[] = { +static const struct qmi_msg_handler qcom_slim_qmi_msg_handlers[] = { { .type = QMI_RESPONSE, .msg_id = SLIMBUS_QMI_POWER_RESP_V01, @@ -1309,7 +1309,7 @@ static void qcom_slim_ngd_qmi_del_server(struct qmi_handle *hdl, qmi->svc_info.sq_port = 0; } -static struct qmi_ops qcom_slim_ngd_qmi_svc_event_ops = { +static const struct qmi_ops qcom_slim_ngd_qmi_svc_event_ops = { .new_server = qcom_slim_ngd_qmi_new_server, .del_server = qcom_slim_ngd_qmi_del_server, };
qcom_slim_qmi_msg_handlers[] and qcom_slim_ngd_qmi_svc_event_ops are only used as input arguments to qmi_handle_init() which accepts const pointers to both qmi_ops and qmi_msg_handler. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/slimbus/qcom-ngd-ctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)