| Message ID | 20201124124538.660710-71-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Convert DSI code to use drm_mipi_dsi and drm_panel | expand |
On Tue, Nov 24, 2020 at 02:45:28PM +0200, Tomi Valkeinen wrote: > Drop unneeded includes. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> I trust the compiler here. Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > --- > drivers/gpu/drm/panel/panel-dsi-cm.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel/panel-dsi-cm.c > index ec87b785871f..91ed8237a1c2 100644 > --- a/drivers/gpu/drm/panel/panel-dsi-cm.c > +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c > @@ -9,12 +9,7 @@ > #include <linux/backlight.h> > #include <linux/delay.h> > #include <linux/gpio/consumer.h> > -#include <linux/interrupt.h> > #include <linux/jiffies.h> > -#include <linux/module.h> > -#include <linux/sched/signal.h> > -#include <linux/slab.h> > -#include <linux/of_device.h> > #include <linux/regulator/consumer.h> > > #include <drm/drm_connector.h> > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:28PM +0200, Tomi Valkeinen wrote: > Drop unneeded includes. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > --- > drivers/gpu/drm/panel/panel-dsi-cm.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel/panel-dsi-cm.c > index ec87b785871f..91ed8237a1c2 100644 > --- a/drivers/gpu/drm/panel/panel-dsi-cm.c > +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c > @@ -9,12 +9,7 @@ > #include <linux/backlight.h> > #include <linux/delay.h> > #include <linux/gpio/consumer.h> > -#include <linux/interrupt.h> This could go to the patch that moves TE handling to the code. > #include <linux/jiffies.h> > -#include <linux/module.h> I'd keep module.h as you use macros it defines, and we shouldn't depend in indirect includes. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > -#include <linux/sched/signal.h> > -#include <linux/slab.h> > -#include <linux/of_device.h> > #include <linux/regulator/consumer.h> > > #include <drm/drm_connector.h>
On 01/12/2020 02:27, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tue, Nov 24, 2020 at 02:45:28PM +0200, Tomi Valkeinen wrote: >> Drop unneeded includes. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> >> --- >> drivers/gpu/drm/panel/panel-dsi-cm.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel/panel-dsi-cm.c >> index ec87b785871f..91ed8237a1c2 100644 >> --- a/drivers/gpu/drm/panel/panel-dsi-cm.c >> +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c >> @@ -9,12 +9,7 @@ >> #include <linux/backlight.h> >> #include <linux/delay.h> >> #include <linux/gpio/consumer.h> >> -#include <linux/interrupt.h> > > This could go to the patch that moves TE handling to the code. True. >> #include <linux/jiffies.h> >> -#include <linux/module.h> > > I'd keep module.h as you use macros it defines, and we shouldn't depend > in indirect includes. Ok. Tomi
diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel/panel-dsi-cm.c index ec87b785871f..91ed8237a1c2 100644 --- a/drivers/gpu/drm/panel/panel-dsi-cm.c +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c @@ -9,12 +9,7 @@ #include <linux/backlight.h> #include <linux/delay.h> #include <linux/gpio/consumer.h> -#include <linux/interrupt.h> #include <linux/jiffies.h> -#include <linux/module.h> -#include <linux/sched/signal.h> -#include <linux/slab.h> -#include <linux/of_device.h> #include <linux/regulator/consumer.h> #include <drm/drm_connector.h>
Drop unneeded includes. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> --- drivers/gpu/drm/panel/panel-dsi-cm.c | 5 ----- 1 file changed, 5 deletions(-)