| Message ID | 20201127104144.GJ4351@valkosipuli.retiisi.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [GIT,PULL,v2,for,5.11] Smiapp driver fixes, begin conversion to CCS | expand |
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/20201127104144.GJ4351@valkosipuli.retiisi.org.uk/
Build log: https://builder.linuxtv.org/job/patchwork/78839/
Build time: 00:13:30
Link: https://lore.kernel.org/linux-media/20201127104144.GJ4351@valkosipuli.retiisi.org.uk
gpg: Signature made Fri 27 Nov 2020 10:36:35 AM UTC
gpg: using DSA key 53AC58A5F5948636C04A1BF8141DFA54A1EC8DEA
gpg: issuer "sakari.ailus@linux.intel.com"
gpg: Can't check signature: No public key
Summary: got 11/29 patches with issues, being 1 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0001-ccs-Add-the-generator-for-CCS-register-definitions-a.patch:
checkpatch.pl:
$ cat patches/0001-ccs-Add-the-generator-for-CCS-register-definitions-a.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:1074: ERROR: do not set execute permissions for source files
patches/0002-Documentation-ccs-Add-CCS-driver-documentation.patch:
checkpatch.pl:
$ cat patches/0002-Documentation-ccs-Add-CCS-driver-documentation.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:16: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
patches/0003-smiapp-Import-CCS-definitions.patch:
checkpatch.pl:
$ cat patches/0003-smiapp-Import-CCS-definitions.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:21: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
-:197: WARNING: line length of 109 exceeds 100 columns
-:198: WARNING: line length of 125 exceeds 100 columns
-:200: WARNING: line length of 109 exceeds 100 columns
-:201: WARNING: line length of 125 exceeds 100 columns
-:235: WARNING: line length of 101 exceeds 100 columns
-:246: WARNING: line length of 103 exceeds 100 columns
-:702: WARNING: line length of 104 exceeds 100 columns
-:881: WARNING: line length of 116 exceeds 100 columns
-:1012: WARNING: line length of 110 exceeds 100 columns
-:1013: WARNING: line length of 110 exceeds 100 columns
-:1016: WARNING: line length of 110 exceeds 100 columns
-:1017: WARNING: line length of 110 exceeds 100 columns
-:1020: WARNING: line length of 110 exceeds 100 columns
-:1021: WARNING: line length of 110 exceeds 100 columns
-:1024: WARNING: line length of 110 exceeds 100 columns
-:1025: WARNING: line length of 110 exceeds 100 columns
-:1026: WARNING: line length of 110 exceeds 100 columns
-:1027: WARNING: line length of 110 exceeds 100 columns
-:1057: WARNING: line length of 110 exceeds 100 columns
-:1058: WARNING: line length of 110 exceeds 100 columns
-:1061: WARNING: line length of 110 exceeds 100 columns
-:1062: WARNING: line length of 110 exceeds 100 columns
-:1086: WARNING: line length of 110 exceeds 100 columns
-:1087: WARNING: line length of 110 exceeds 100 columns
-:1090: WARNING: line length of 110 exceeds 100 columns
-:1091: WARNING: line length of 110 exceeds 100 columns
-:1175: WARNING: line length of 110 exceeds 100 columns
-:1176: WARNING: line length of 110 exceeds 100 columns
-:1177: WARNING: line length of 110 exceeds 100 columns
-:1178: WARNING: line length of 110 exceeds 100 columns
-:1179: WARNING: line length of 104 exceeds 100 columns
-:1180: WARNING: line length of 104 exceeds 100 columns
-:1253: WARNING: line length of 151 exceeds 100 columns
-:1253: CHECK: Macro argument reuse 'n' - possible side-effects?
-:1260: WARNING: line length of 151 exceeds 100 columns
-:1260: CHECK: Macro argument reuse 'n' - possible side-effects?
patches/0006-smiapp-Remove-macros-for-defining-registers-merge-de.patch:
checkpatch.pl:
$ cat patches/0006-smiapp-Remove-macros-for-defining-registers-merge-de.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:546: WARNING: line length of 121 exceeds 100 columns
-:547: WARNING: line length of 120 exceeds 100 columns
-:559: WARNING: line length of 102 exceeds 100 columns
-:884: WARNING: line length of 108 exceeds 100 columns
-:885: WARNING: line length of 108 exceeds 100 columns
-:888: WARNING: line length of 108 exceeds 100 columns
-:889: WARNING: line length of 108 exceeds 100 columns
-:892: WARNING: line length of 108 exceeds 100 columns
-:893: WARNING: line length of 108 exceeds 100 columns
-:896: WARNING: line length of 108 exceeds 100 columns
-:897: WARNING: line length of 108 exceeds 100 columns
-:898: WARNING: line length of 108 exceeds 100 columns
-:899: WARNING: line length of 108 exceeds 100 columns
-:911: WARNING: line length of 108 exceeds 100 columns
-:912: WARNING: line length of 108 exceeds 100 columns
-:915: WARNING: line length of 108 exceeds 100 columns
-:916: WARNING: line length of 108 exceeds 100 columns
-:1091: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
patches/0009-smiapp-Read-CCS-limit-values.patch:
allmodconfig: return code #0:
../drivers/media/i2c/smiapp/smiapp-core.c:161:12: warning: ‘ccs_get_limit’ defined but not used [-Wunused-function]
patches/0010-smiapp-Switch-to-CCS-limits.patch:
checkpatch.pl:
$ cat patches/0010-smiapp-Switch-to-CCS-limits.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:518: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
patches/0014-smiapp-Use-CCS-registers.patch:
checkpatch.pl:
$ cat patches/0014-smiapp-Use-CCS-registers.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:133: CHECK: Lines should not end with a '['
-:144: CHECK: Lines should not end with a '['
-:256: CHECK: Logical continuations should be on the previous line
-:469: CHECK: Lines should not end with a '('
-:478: CHECK: Lines should not end with a '('
-:489: CHECK: Lines should not end with a '('
-:497: CHECK: Lines should not end with a '('
-:505: CHECK: Lines should not end with a '('
-:513: CHECK: Lines should not end with a '('
patches/0016-smiapp-Rename-register-access-functions.patch:
checkpatch.pl:
$ cat patches/0016-smiapp-Rename-register-access-functions.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:264: CHECK: Alignment should match open parenthesis
-:269: CHECK: Alignment should match open parenthesis
-:281: CHECK: Lines should not end with a '('
patches/0017-smiapp-Internal-rename-to-CCS.patch:
checkpatch.pl:
$ cat patches/0017-smiapp-Internal-rename-to-CCS.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:15: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
-:53: WARNING: It's generally not useful to have the filename in the file
-:66: CHECK: Macro argument reuse 'dim' - possible side-effects?
-:1615: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
-:1636: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
-:2224: WARNING: It's generally not useful to have the filename in the file
-:2380: WARNING: It's generally not useful to have the filename in the file
-:2427: CHECK: Prefer using the BIT macro
-:2443: CHECK: Macro argument reuse 'sensor' - possible side-effects?
-:2443: CHECK: Macro argument reuse '_quirk' - possible side-effects?
-:2443: CHECK: Macro argument '_quirk' may be better as '(_quirk)' to avoid precedence issues
-:2449: CHECK: Macro argument reuse 'sensor' - possible side-effects?
-:2449: CHECK: Macro argument '_quirk' may be better as '(_quirk)' to avoid precedence issues
-:2659: WARNING: It's generally not useful to have the filename in the file
-:2737: CHECK: Prefer kernel type 'u32' over 'uint32_t'
-:2751: CHECK: Prefer using the BIT macro
patches/0019-smiapp-Rename-as-ccs.patch:
checkpatch.pl:
$ cat patches/0019-smiapp-Rename-as-ccs.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:159: WARNING: It's generally not useful to have the filename in the file
-:192: WARNING: It's generally not useful to have the filename in the file
-:212: WARNING: It's generally not useful to have the filename in the file
-:232: WARNING: It's generally not useful to have the filename in the file
patches/0025-dt-bindings-nokia-smia-Convert-to-YAML.patch:
checkpatch.pl:
$ cat patches/0025-dt-bindings-nokia-smia-Convert-to-YAML.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:24: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
-:93: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
Error #512 when building PDF docs
Hi Mauro, Here's a set that prepares making the smiapp driver a modern MIPI CCS driver. It includes bugfixes, switch to CCS limit definitions as well as includes the DT bindings for the CCS device. This corresponds to the v2, changes to v1 are: - Fix the SPDX tag in mk-ccs-regs script - Add support for producing kernel definitions including use of BIT macro and kernel types in mk-ccs-regs (was C99 only) - Add MAINTAINERS entry for the documentation in the first documentation patch. - Fix compilation issues due to ccs-limits.o missing from Makefile in a few patches early in the set. Please pull. The following changes since commit 9463e07df8e0f93931e32c6f415d3f82bda63f35: media: v4l2-compat-ioctl32.c: add missing #ifdef CONFIG_COMPAT_32BIT_TIMEs (2020-11-17 07:14:46 +0100) are available in the Git repository at: git://linuxtv.org/sailus/media_tree.git tags/ccs-v4-smiapp-signed for you to fetch changes up to c58bbf359f8b7156e3d815208a3bb624bae1f486: ccs: Request for "reset" GPIO (2020-11-27 12:20:30 +0200) ---------------------------------------------------------------- Preparation of CCS driver for 5.11 ---------------------------------------------------------------- Sakari Ailus (29): ccs: Add the generator for CCS register definitions and limits Documentation: ccs: Add CCS driver documentation smiapp: Import CCS definitions smiapp: Use CCS register flags smiapp: Calculate CCS limit offsets and limit buffer size smiapp: Remove macros for defining registers, merge definitions smiapp: Add macros for accessing CCS registers smiapp: Use MIPI CCS version and manufacturer ID information smiapp: Read CCS limit values smiapp: Switch to CCS limits smiapp: Obtain frame descriptor from CCS limits smiapp: Use CCS limits in reading data format descriptors smiapp: Use CCS limits in reading binning capabilities smiapp: Use CCS registers smiapp: Remove quirk function for writing a single 8-bit register smiapp: Rename register access functions smiapp: Internal rename to CCS smiapp: Differentiate CCS sensors from SMIA in subdev naming smiapp: Rename as "ccs" ccs: Remove profile concept ccs: Give all subdevs a function dt-bindings: nokia,smia: Fix link-frequencies documentation dt-bindings: nokia,smia: Make vana-supply optional dt-bindings: nokia,smia: Remove nokia,nvm-size property dt-bindings: nokia,smia: Convert to YAML dt-bindings: nokia,smia: Use better active polarity for reset dt-bindings: nokia,smia: Amend SMIA bindings with MIPI CCS support dt-bindings: mipi-ccs: Add bus-type for C-PHY support ccs: Request for "reset" GPIO .../devicetree/bindings/media/i2c/mipi-ccs.yaml | 128 ++ .../devicetree/bindings/media/i2c/nokia,smia.txt | 66 - .../driver-api/media/drivers/ccs/ccs-regs.txt | 1041 +++++++++++ Documentation/driver-api/media/drivers/ccs/ccs.rst | 82 + .../driver-api/media/drivers/ccs/mk-ccs-regs | 433 +++++ Documentation/driver-api/media/drivers/index.rst | 1 + MAINTAINERS | 21 +- drivers/media/i2c/Kconfig | 2 +- drivers/media/i2c/Makefile | 2 +- drivers/media/i2c/{smiapp => ccs}/Kconfig | 7 +- drivers/media/i2c/ccs/Makefile | 6 + .../i2c/{smiapp/smiapp-core.c => ccs/ccs-core.c} | 1828 +++++++++++--------- drivers/media/i2c/ccs/ccs-limits.c | 239 +++ drivers/media/i2c/ccs/ccs-limits.h | 259 +++ .../i2c/{smiapp/smiapp-quirk.c => ccs/ccs-quirk.c} | 92 +- .../i2c/{smiapp/smiapp-quirk.h => ccs/ccs-quirk.h} | 52 +- .../{smiapp/smiapp-regs.c => ccs/ccs-reg-access.c} | 85 +- drivers/media/i2c/ccs/ccs-reg-access.h | 38 + drivers/media/i2c/ccs/ccs-regs.h | 954 ++++++++++ drivers/media/i2c/{smiapp/smiapp.h => ccs/ccs.h} | 164 +- drivers/media/i2c/ccs/smiapp-reg-defs.h | 580 +++++++ drivers/media/i2c/smiapp/Makefile | 6 - drivers/media/i2c/smiapp/smiapp-limits.c | 118 -- drivers/media/i2c/smiapp/smiapp-limits.h | 114 -- drivers/media/i2c/smiapp/smiapp-reg-defs.h | 489 ------ drivers/media/i2c/smiapp/smiapp-reg.h | 116 -- drivers/media/i2c/smiapp/smiapp-regs.h | 36 - 27 files changed, 4947 insertions(+), 2012 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml delete mode 100644 Documentation/devicetree/bindings/media/i2c/nokia,smia.txt create mode 100644 Documentation/driver-api/media/drivers/ccs/ccs-regs.txt create mode 100644 Documentation/driver-api/media/drivers/ccs/ccs.rst create mode 100755 Documentation/driver-api/media/drivers/ccs/mk-ccs-regs rename drivers/media/i2c/{smiapp => ccs}/Kconfig (55%) create mode 100644 drivers/media/i2c/ccs/Makefile rename drivers/media/i2c/{smiapp/smiapp-core.c => ccs/ccs-core.c} (53%) create mode 100644 drivers/media/i2c/ccs/ccs-limits.c create mode 100644 drivers/media/i2c/ccs/ccs-limits.h rename drivers/media/i2c/{smiapp/smiapp-quirk.c => ccs/ccs-quirk.c} (66%) rename drivers/media/i2c/{smiapp/smiapp-quirk.h => ccs/ccs-quirk.h} (55%) rename drivers/media/i2c/{smiapp/smiapp-regs.c => ccs/ccs-reg-access.c} (66%) create mode 100644 drivers/media/i2c/ccs/ccs-reg-access.h create mode 100644 drivers/media/i2c/ccs/ccs-regs.h rename drivers/media/i2c/{smiapp/smiapp.h => ccs/ccs.h} (57%) create mode 100644 drivers/media/i2c/ccs/smiapp-reg-defs.h delete mode 100644 drivers/media/i2c/smiapp/Makefile delete mode 100644 drivers/media/i2c/smiapp/smiapp-limits.c delete mode 100644 drivers/media/i2c/smiapp/smiapp-limits.h delete mode 100644 drivers/media/i2c/smiapp/smiapp-reg-defs.h delete mode 100644 drivers/media/i2c/smiapp/smiapp-reg.h delete mode 100644 drivers/media/i2c/smiapp/smiapp-regs.h