diff mbox series

[2/2] ARM: multi_v7_defconfig: drop unused POWER_AVS option

Message ID 20201130112731.30599-3-andrey.zhizhikin@leica-geosystems.com (mailing list archive)
State New, archived
Headers show
Series drop unused POWER_AVS option for ARM/ARM64 config | expand

Commit Message

ZHIZHIKIN Andrey Nov. 30, 2020, 11:27 a.m. UTC
Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
corresponding Kconfig") moved AVS code to SOC-specific folders, and
removed corresponding Kconfig from drivers/power, leaving original
POWER_AVS config option enabled in multi_v7_defconfig file.

Remove the option, which has no references in the tree anymore.

Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the corresponding Kconfig")
Cc: Nishanth Menon <nm@ti.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
---
 arch/arm/configs/multi_v7_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Nishanth Menon Nov. 30, 2020, 12:22 p.m. UTC | #1
On 11:27-20201130, Andrey Zhizhikin wrote:
> Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> corresponding Kconfig") moved AVS code to SOC-specific folders, and
> removed corresponding Kconfig from drivers/power, leaving original
> POWER_AVS config option enabled in multi_v7_defconfig file.
> 
> Remove the option, which has no references in the tree anymore.
> 
> Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the corresponding Kconfig")
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>

Reviewed-by: Nishanth Menon <nm@ti.com>
Krzysztof Kozlowski Nov. 30, 2020, 12:22 p.m. UTC | #2
On Mon, Nov 30, 2020 at 11:27:31AM +0000, Andrey Zhizhikin wrote:
> Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> corresponding Kconfig") moved AVS code to SOC-specific folders, and
> removed corresponding Kconfig from drivers/power, leaving original
> POWER_AVS config option enabled in multi_v7_defconfig file.
> 
> Remove the option, which has no references in the tree anymore.
> 
> Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the corresponding Kconfig")
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>

Thanks for the patch. You should also remove it from the omap2plus config.

Best regards,
Krzysztof
ZHIZHIKIN Andrey Nov. 30, 2020, 12:37 p.m. UTC | #3
Hello Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Monday, November 30, 2020 1:23 PM
> To: ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com>
> Cc: catalin.marinas@arm.com; will@kernel.org; bjorn.andersson@linaro.org;
> shawnguo@kernel.org; leoyang.li@nxp.com; vkoul@kernel.org;
> geert+renesas@glider.be; Anson.Huang@nxp.com; michael@walle.cc;
> olof@lixom.net; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Nishanth Menon <nm@ti.com>; Ulf Hansson
> <ulf.hansson@linaro.org>
> Subject: Re: [PATCH 2/2] ARM: multi_v7_defconfig: drop unused
> POWER_AVS option
> 
> This email is not from Hexagon’s Office 365 instance. Please be careful while
> clicking links, opening attachments, or replying to this email.
> 
> 
> On Mon, Nov 30, 2020 at 11:27:31AM +0000, Andrey Zhizhikin wrote:
> > Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> > corresponding Kconfig") moved AVS code to SOC-specific folders, and
> > removed corresponding Kconfig from drivers/power, leaving original
> > POWER_AVS config option enabled in multi_v7_defconfig file.
> >
> > Remove the option, which has no references in the tree anymore.
> >
> > Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> > corresponding Kconfig")
> > Cc: Nishanth Menon <nm@ti.com>
> > Cc: Ulf Hansson <ulf.hansson@linaro.org>
> > Signed-off-by: Andrey Zhizhikin
> > <andrey.zhizhikin@leica-geosystems.com>
> 
> Thanks for the patch. You should also remove it from the omap2plus config.

True, just realized this config option is present in arch/arm/configs/omap2plus_defconfig. Thanks for pointing this out, would submit a separate patch to take care of it now.

> 
> Best regards,
> Krzysztof

Regards,
Andrey
Krzysztof Kozlowski Nov. 30, 2020, 12:56 p.m. UTC | #4
On Mon, Nov 30, 2020 at 11:27:31AM +0000, Andrey Zhizhikin wrote:
> Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> corresponding Kconfig") moved AVS code to SOC-specific folders, and
> removed corresponding Kconfig from drivers/power, leaving original
> POWER_AVS config option enabled in multi_v7_defconfig file.
> 
> Remove the option, which has no references in the tree anymore.
> 
> Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the corresponding Kconfig")
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> ---
>  arch/arm/configs/multi_v7_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index a611b0c1e540..91752d918d34 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -466,7 +466,6 @@  CONFIG_GPIO_TPS6586X=y
 CONFIG_GPIO_TPS65910=y
 CONFIG_GPIO_TWL4030=y
 CONFIG_GPIO_MXC=y
-CONFIG_POWER_AVS=y
 CONFIG_ROCKCHIP_IODOMAIN=y
 CONFIG_POWER_RESET_AS3722=y
 CONFIG_POWER_RESET_GPIO=y