| Message ID | 20201130113047.9659-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c7721e15f434920145c376e8fe77e1c079fc3726 |
| Headers | show |
| Series | [v2] usb: chipidea: ci_hdrc_imx: Pass DISABLE_DEVICE_STREAMING flag to imx6ul | expand |
On 20-11-30 08:30:47, Fabio Estevam wrote: > According to the i.MX6UL Errata document: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.nxp.com%2Fdocs%2Fen%2Ferrata%2FIMX6ULCE.pdf&data=04%7C01%7CPeter.Chen%40nxp.com%7C2d4f5ecc4fbf4100891808d89523674c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637423326572381531%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=lIBiWvdeey56ihYUwT8nE%2B26GTykl67aQ2liekzOYt0%3D&reserved=0 > > ERR007881 also affects i.MX6UL, so pass the > CI_HDRC_DISABLE_DEVICE_STREAMING flag to workaround the issue. > > Cc: <stable@vger.kernel.org> > Fixes: 52fe568e5d71 ("usb: chipidea: imx: add imx6ul usb support") > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- > Changes since v1: > - Use the CI_HDRC_DISABLE_DEVICE_STREAMING flag instead - Peter > > drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c > index 25c65accf089..5e07a0a86d11 100644 > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c > @@ -57,7 +57,8 @@ static const struct ci_hdrc_imx_platform_flag imx6sx_usb_data = { > > static const struct ci_hdrc_imx_platform_flag imx6ul_usb_data = { > .flags = CI_HDRC_SUPPORTS_RUNTIME_PM | > - CI_HDRC_TURN_VBUS_EARLY_ON, > + CI_HDRC_TURN_VBUS_EARLY_ON | > + CI_HDRC_DISABLE_DEVICE_STREAMING, > }; > > static const struct ci_hdrc_imx_platform_flag imx7d_usb_data = { > -- Applied, thanks.
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 25c65accf089..5e07a0a86d11 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -57,7 +57,8 @@ static const struct ci_hdrc_imx_platform_flag imx6sx_usb_data = { static const struct ci_hdrc_imx_platform_flag imx6ul_usb_data = { .flags = CI_HDRC_SUPPORTS_RUNTIME_PM | - CI_HDRC_TURN_VBUS_EARLY_ON, + CI_HDRC_TURN_VBUS_EARLY_ON | + CI_HDRC_DISABLE_DEVICE_STREAMING, }; static const struct ci_hdrc_imx_platform_flag imx7d_usb_data = {
According to the i.MX6UL Errata document: https://www.nxp.com/docs/en/errata/IMX6ULCE.pdf ERR007881 also affects i.MX6UL, so pass the CI_HDRC_DISABLE_DEVICE_STREAMING flag to workaround the issue. Cc: <stable@vger.kernel.org> Fixes: 52fe568e5d71 ("usb: chipidea: imx: add imx6ul usb support") Signed-off-by: Fabio Estevam <festevam@gmail.com> --- Changes since v1: - Use the CI_HDRC_DISABLE_DEVICE_STREAMING flag instead - Peter drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)