diff mbox series

net: bna: remove trailing semicolon in macro definition

Message ID 20201127165550.2693417-1-trix@redhat.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series net: bna: remove trailing semicolon in macro definition | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 262 this patch: 262
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 16 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 262 this patch: 262
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Tom Rix Nov. 27, 2020, 4:55 p.m. UTC 
From: Tom Rix <trix@redhat.com>

The macro use will already have a semicolon.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jakub Kicinski Dec. 1, 2020, 3:01 a.m. UTC | #1 
On Fri, 27 Nov 2020 08:55:50 -0800 trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> The macro use will already have a semicolon.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
> index f335b7115c1b..4b19855017d7 100644
> --- a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
> +++ b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
> @@ -218,7 +218,7 @@ do {									\
>  
>  /* Set the coalescing timer for the given ib */
>  #define bna_ib_coalescing_timer_set(_i_dbell, _cls_timer)		\
> -	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0));
> +	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0))
>  
>  /* Acks 'events' # of events for a given ib while disabling interrupts */
>  #define bna_ib_ack_disable_irq(_i_dbell, _events)			\
> @@ -260,7 +260,7 @@ do {									\
>  
>  #define bna_txq_prod_indx_doorbell(_tcb)				\
>  	(writel(BNA_DOORBELL_Q_PRD_IDX((_tcb)->producer_index), \
> -		(_tcb)->q_dbell));
> +		(_tcb)->q_dbell))
>  
>  #define bna_rxq_prod_indx_doorbell(_rcb)				\
>  	(writel(BNA_DOORBELL_Q_PRD_IDX((_rcb)->producer_index), \

Same story here as Daniel pointed out for the BPF patch.

There are 2 macros right below here which also have a semicolon at the
end. And these ones are used. So the patch appears to be pretty arbitrary.
Tom Rix Dec. 1, 2020, 5:25 p.m. UTC | #2 
On 11/30/20 7:01 PM, Jakub Kicinski wrote:
> On Fri, 27 Nov 2020 08:55:50 -0800 trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>  drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
>> index f335b7115c1b..4b19855017d7 100644
>> --- a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
>> +++ b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
>> @@ -218,7 +218,7 @@ do {									\
>>  
>>  /* Set the coalescing timer for the given ib */
>>  #define bna_ib_coalescing_timer_set(_i_dbell, _cls_timer)		\
>> -	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0));
>> +	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0))
>>  
>>  /* Acks 'events' # of events for a given ib while disabling interrupts */
>>  #define bna_ib_ack_disable_irq(_i_dbell, _events)			\
>> @@ -260,7 +260,7 @@ do {									\
>>  
>>  #define bna_txq_prod_indx_doorbell(_tcb)				\
>>  	(writel(BNA_DOORBELL_Q_PRD_IDX((_tcb)->producer_index), \
>> -		(_tcb)->q_dbell));
>> +		(_tcb)->q_dbell))
>>  
>>  #define bna_rxq_prod_indx_doorbell(_rcb)				\
>>  	(writel(BNA_DOORBELL_Q_PRD_IDX((_rcb)->producer_index), \
> Same story here as Daniel pointed out for the BPF patch.
>
> There are 2 macros right below here which also have a semicolon at the
> end. And these ones are used. So the patch appears to be pretty arbitrary.

I will add the other macros in the next revision.

Sorry,

Tom

>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
index f335b7115c1b..4b19855017d7 100644
--- a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
+++ b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
@@ -218,7 +218,7 @@  do {									\
 
 /* Set the coalescing timer for the given ib */
 #define bna_ib_coalescing_timer_set(_i_dbell, _cls_timer)		\
-	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0));
+	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0))
 
 /* Acks 'events' # of events for a given ib while disabling interrupts */
 #define bna_ib_ack_disable_irq(_i_dbell, _events)			\
@@ -260,7 +260,7 @@  do {									\
 
 #define bna_txq_prod_indx_doorbell(_tcb)				\
 	(writel(BNA_DOORBELL_Q_PRD_IDX((_tcb)->producer_index), \
-		(_tcb)->q_dbell));
+		(_tcb)->q_dbell))
 
 #define bna_rxq_prod_indx_doorbell(_rcb)				\
 	(writel(BNA_DOORBELL_Q_PRD_IDX((_rcb)->producer_index), \