| Message ID | X8eoN/jMAJb3H3iv@mwanda (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Headers | show |
| Series | x86/platform/uv: Fix an error code in uv_hubs_init() | expand |
On Wed, Dec 02, 2020 at 05:44:07PM +0300, Dan Carpenter wrote:
> Return -ENOMEM on allocation failure instead of returning success.
s/success/random stack memory contents/
> Return -ENOMEM on allocation failure instead of returning success. > > Fixes: 4fc2cf1f2daf ("x86/platform/uv: Add new uv_sysfs platform driver") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Thank you for taking the time to find this. Reviewed-by: Justin Ernst <justin.ernst@hpe.com> (With an acknowledgement of Boris's 's/success/random stack memory contents/' comment) > --- > drivers/platform/x86/uv_sysfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c > index 54c342579f1c..e17ce8c4cdad 100644 > --- a/drivers/platform/x86/uv_sysfs.c > +++ b/drivers/platform/x86/uv_sysfs.c > @@ -248,6 +248,7 @@ static int uv_hubs_init(void) > uv_hubs[i] = kzalloc(sizeof(*uv_hubs[i]), GFP_KERNEL); > if (!uv_hubs[i]) { > i--; > + ret = -ENOMEM; > goto err_hubs; > } > > -- > 2.29.2
Hi, On 12/2/20 9:50 PM, Ernst, Justin wrote: >> Return -ENOMEM on allocation failure instead of returning success. >> >> Fixes: 4fc2cf1f2daf ("x86/platform/uv: Add new uv_sysfs platform driver") >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Thank you for taking the time to find this. > > Reviewed-by: Justin Ernst <justin.ernst@hpe.com> > (With an acknowledgement of Boris's 's/success/random stack memory contents/' comment) ATM the drivers/platform/x86/uv_sysfs.c only exists in the tip/x86 tree -next branch, so this fix needs to be merged through the tip/x86 tree, here is my ack for merging it that way: Acked-by: Hans de Goede <hdegoede@redhat.com> (either with a fixed up commit-msg as suggested by Borislav, or feel free to add it to a fixed v2 of the patch) Regards, Hans > >> --- >> drivers/platform/x86/uv_sysfs.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c >> index 54c342579f1c..e17ce8c4cdad 100644 >> --- a/drivers/platform/x86/uv_sysfs.c >> +++ b/drivers/platform/x86/uv_sysfs.c >> @@ -248,6 +248,7 @@ static int uv_hubs_init(void) >> uv_hubs[i] = kzalloc(sizeof(*uv_hubs[i]), GFP_KERNEL); >> if (!uv_hubs[i]) { >> i--; >> + ret = -ENOMEM; >> goto err_hubs; >> } >> >> -- >> 2.29.2 >
diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c index 54c342579f1c..e17ce8c4cdad 100644 --- a/drivers/platform/x86/uv_sysfs.c +++ b/drivers/platform/x86/uv_sysfs.c @@ -248,6 +248,7 @@ static int uv_hubs_init(void) uv_hubs[i] = kzalloc(sizeof(*uv_hubs[i]), GFP_KERNEL); if (!uv_hubs[i]) { i--; + ret = -ENOMEM; goto err_hubs; }
Return -ENOMEM on allocation failure instead of returning success. Fixes: 4fc2cf1f2daf ("x86/platform/uv: Add new uv_sysfs platform driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/platform/x86/uv_sysfs.c | 1 + 1 file changed, 1 insertion(+)