| Message ID | 20201125072634.27664-1-manasi.d.navare@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/dp: No need to poll FEC Enable Live bit | expand |
On 11/25/2020 12:56 PM, Manasi Navare wrote: > The Bspec does not mention polling the FEC Enable > Live status bit. That is only there for debug purposes. > So remove the polling from driver. > > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 92940a0c5ef8..6b3edd7e4423 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -3507,12 +3507,6 @@ static void intel_ddi_enable_fec(struct intel_encoder *encoder, > val = intel_de_read(dev_priv, dp_tp_ctl_reg(encoder, crtc_state)); > val |= DP_TP_CTL_FEC_ENABLE; > intel_de_write(dev_priv, dp_tp_ctl_reg(encoder, crtc_state), val); > - > - if (intel_de_wait_for_set(dev_priv, > - dp_tp_status_reg(encoder, crtc_state), > - DP_TP_STATUS_FEC_ENABLE_LIVE, 1)) > - drm_err(&dev_priv->drm, > - "Timed out waiting for FEC Enable Status\n"); > } > > static void intel_ddi_disable_fec_state(struct intel_encoder *encoder, Looks good to me. Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 92940a0c5ef8..6b3edd7e4423 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -3507,12 +3507,6 @@ static void intel_ddi_enable_fec(struct intel_encoder *encoder, val = intel_de_read(dev_priv, dp_tp_ctl_reg(encoder, crtc_state)); val |= DP_TP_CTL_FEC_ENABLE; intel_de_write(dev_priv, dp_tp_ctl_reg(encoder, crtc_state), val); - - if (intel_de_wait_for_set(dev_priv, - dp_tp_status_reg(encoder, crtc_state), - DP_TP_STATUS_FEC_ENABLE_LIVE, 1)) - drm_err(&dev_priv->drm, - "Timed out waiting for FEC Enable Status\n"); } static void intel_ddi_disable_fec_state(struct intel_encoder *encoder,
The Bspec does not mention polling the FEC Enable Live status bit. That is only there for debug purposes. So remove the polling from driver. Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> --- drivers/gpu/drm/i915/display/intel_ddi.c | 6 ------ 1 file changed, 6 deletions(-)