diff mbox series

[-V7,2/3] NOT kernel/man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING

Message ID 20201204091534.72239-3-ying.huang@intel.com (mailing list archive)
State New, archived
Headers show
Series numa balancing: Migrate on fault among multiple bound nodes | expand

Commit Message

Huang, Ying Dec. 4, 2020, 9:15 a.m. UTC
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
---
 man2/set_mempolicy.2 | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Alejandro Colomar Dec. 4, 2020, 1:25 p.m. UTC | #1
Hi Huang Ying,

Please, see a few fixes below.

Thanks,

Alex

On 12/4/20 10:15 AM, Huang Ying wrote:
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> ---
>  man2/set_mempolicy.2 | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
> index 68011eecb..fb2e6fd96 100644
> --- a/man2/set_mempolicy.2
> +++ b/man2/set_mempolicy.2
> @@ -113,6 +113,15 @@ A nonempty
>  .I nodemask
>  specifies node IDs that are relative to the set of
>  node IDs allowed by the process's current cpuset.
> +.TP
> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
> +When
> +.I mode
> +is MPOL_BIND, enable the Linux kernel NUMA balancing for the task if

.B MPOL_BIND

> +it is supported by kernel.
> +If the flag isn't supported by Linux kernel, or is used with
> +.I mode> +other than MPOL_BIND, return -1 and errno is set to EINVAL.

.BR MPOL_BIND ,

A minus sign should be escaped:
\-1
See man-pages(7)::STYLE GUIDE::Generating optimal glyphs)

.I errno
.BR EINVAL .

>  .PP
>  .I nodemask
>  points to a bit mask of node IDs that contains up to
> @@ -293,6 +302,11 @@ argument specified both
>  .B MPOL_F_STATIC_NODES
>  and
>  .BR MPOL_F_RELATIVE_NODES .
> +Or, the
> +.B MPOL_F_NUMA_BALANCING
> +isn't supported by the Linux kernel, or is used with
> +.I mode
> +other than MPOL_BIND.

.BR MPOL_BIND .

>  .TP
>  .B ENOMEM
>  Insufficient kernel memory was available.
>
Huang, Ying Dec. 7, 2020, 12:48 a.m. UTC | #2
Hi, Alex,

"Alejandro Colomar (man-pages)" <alx.manpages@gmail.com> writes:

> Hi Huang Ying,
>
> Please, see a few fixes below.
>
> Thanks,
>
> Alex
>
> On 12/4/20 10:15 AM, Huang Ying wrote:
>> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
>> ---
>>  man2/set_mempolicy.2 | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>> 
>> diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
>> index 68011eecb..fb2e6fd96 100644
>> --- a/man2/set_mempolicy.2
>> +++ b/man2/set_mempolicy.2
>> @@ -113,6 +113,15 @@ A nonempty
>>  .I nodemask
>>  specifies node IDs that are relative to the set of
>>  node IDs allowed by the process's current cpuset.
>> +.TP
>> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
>> +When
>> +.I mode
>> +is MPOL_BIND, enable the Linux kernel NUMA balancing for the task if
>
> .B MPOL_BIND
>
>> +it is supported by kernel.
>> +If the flag isn't supported by Linux kernel, or is used with
>> +.I mode> +other than MPOL_BIND, return -1 and errno is set to EINVAL.
>
> .BR MPOL_BIND ,
>
> A minus sign should be escaped:
> \-1
> See man-pages(7)::STYLE GUIDE::Generating optimal glyphs)
>
> .I errno
> .BR EINVAL .
>
>>  .PP
>>  .I nodemask
>>  points to a bit mask of node IDs that contains up to
>> @@ -293,6 +302,11 @@ argument specified both
>>  .B MPOL_F_STATIC_NODES
>>  and
>>  .BR MPOL_F_RELATIVE_NODES .
>> +Or, the
>> +.B MPOL_F_NUMA_BALANCING
>> +isn't supported by the Linux kernel, or is used with
>> +.I mode
>> +other than MPOL_BIND.
>
> .BR MPOL_BIND .
>
>>  .TP
>>  .B ENOMEM
>>  Insufficient kernel memory was available.
>> 

Thanks a lot for your comments!  Will change them in the next version.

Best Regards,
Huang, Ying
diff mbox series

Patch

diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
index 68011eecb..fb2e6fd96 100644
--- a/man2/set_mempolicy.2
+++ b/man2/set_mempolicy.2
@@ -113,6 +113,15 @@  A nonempty
 .I nodemask
 specifies node IDs that are relative to the set of
 node IDs allowed by the process's current cpuset.
+.TP
+.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
+When
+.I mode
+is MPOL_BIND, enable the Linux kernel NUMA balancing for the task if
+it is supported by kernel.
+If the flag isn't supported by Linux kernel, or is used with
+.I mode
+other than MPOL_BIND, return -1 and errno is set to EINVAL.
 .PP
 .I nodemask
 points to a bit mask of node IDs that contains up to
@@ -293,6 +302,11 @@  argument specified both
 .B MPOL_F_STATIC_NODES
 and
 .BR MPOL_F_RELATIVE_NODES .
+Or, the
+.B MPOL_F_NUMA_BALANCING
+isn't supported by the Linux kernel, or is used with
+.I mode
+other than MPOL_BIND.
 .TP
 .B ENOMEM
 Insufficient kernel memory was available.