| Message ID | 20201202101521.15405-1-jencce.kernel@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | generic/506: require prjquota | expand |
On Wed, Dec 02, 2020 at 06:15:21PM +0800, Murphy Zhou wrote: > To avoid false failure on overlayfs. > > Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> > --- > tests/generic/506 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/generic/506 b/tests/generic/506 > index d5b28cad..edcda6db 100755 > --- a/tests/generic/506 > +++ b/tests/generic/506 > @@ -42,6 +42,7 @@ rm -f $seqres.full > # real QA test starts here > _supported_fs generic > > +_require_prjquota > _require_scratch > _require_scratch_shutdown generic/506 already has _require_prjquota below, and it requires the device to be mounted first. _qmount_option "prjquota" _qmount _require_prjquota $SCRATCH_DEV So would you please give more details on the failure you want to fix? Thanks, Eryu > > -- > 2.20.1
On Sun, Dec 06, 2020 at 09:21:16PM +0800, Eryu Guan wrote: > On Wed, Dec 02, 2020 at 06:15:21PM +0800, Murphy Zhou wrote: > > To avoid false failure on overlayfs. > > > > Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> > > --- > > tests/generic/506 | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/generic/506 b/tests/generic/506 > > index d5b28cad..edcda6db 100755 > > --- a/tests/generic/506 > > +++ b/tests/generic/506 > > @@ -42,6 +42,7 @@ rm -f $seqres.full > > # real QA test starts here > > _supported_fs generic > > > > +_require_prjquota > > _require_scratch > > _require_scratch_shutdown > > generic/506 already has _require_prjquota below, and it requires the > device to be mounted first. > > _qmount_option "prjquota" > _qmount > _require_prjquota $SCRATCH_DEV > > So would you please give more details on the failure you want to fix? qmount failed on overlayfs. -Silence is golden +mount: /loopsch/ovl-mnt: wrong fs type, bad option, bad superblock on /loopsch, missing codepage or helper program, or other error. +qmount failed> Since it's required to be mounted before checking, I guess it's better to exclue this one for overlayfs. Thanks for reviewing! > Thanks, > Eryu > > > > > -- > > 2.20.1
diff --git a/tests/generic/506 b/tests/generic/506 index d5b28cad..edcda6db 100755 --- a/tests/generic/506 +++ b/tests/generic/506 @@ -42,6 +42,7 @@ rm -f $seqres.full # real QA test starts here _supported_fs generic +_require_prjquota _require_scratch _require_scratch_shutdown
To avoid false failure on overlayfs. Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> --- tests/generic/506 | 1 + 1 file changed, 1 insertion(+)