diff mbox series

[3/4] bindings: arm: fsl: Add PHYTEC i.MX8MP devicetree bindings

Message ID 1607113982-109524-4-git-send-email-t.remmet@phytec.de (mailing list archive)
State New, archived
Headers show
Series Initial support for phyBOARD-Pollux i.MX8MP | expand

Commit Message

Teresa Remmet Dec. 4, 2020, 8:33 p.m. UTC
Add devicetree bindings for i.MX8MP based phyCORE-i.MX8MP
and phyBOARD-Pollux RDK.

Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Krzysztof Kozlowski Dec. 7, 2020, 11:59 a.m. UTC | #1
On Fri, Dec 04, 2020 at 09:33:01PM +0100, Teresa Remmet wrote:
> Add devicetree bindings for i.MX8MP based phyCORE-i.MX8MP
> and phyBOARD-Pollux RDK.
> 
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 934289446abb..880d93092f37 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -433,6 +433,13 @@ properties:
>                - fsl,imx8mp-evk            # i.MX8MP EVK Board
>            - const: fsl,imx8mp
>  
> +      - description: PHYTEC phyCORE-i.MX8MP SoM based boards
> +        items:
> +          - enum:
> +              - phytec,imx8mp-phycore-som         # phyCORE-i.MX8MP SoM
> +              - phytec,imx8mp-phyboard-pollux-rdk # phyBOARD-Pollux RDK

These do not look correct. In this way, you should include them in
"i.MX8MP based Boards" entry. Probably you wanted all "const" instead.

Best regards,
Krzysztof


> +          - const: fsl,imx8mp
> +
Teresa Remmet Dec. 7, 2020, 12:37 p.m. UTC | #2
Am Montag, den 07.12.2020, 12:59 +0100 schrieb Krzysztof Kozlowski:
> On Fri, Dec 04, 2020 at 09:33:01PM +0100, Teresa Remmet wrote:
> > Add devicetree bindings for i.MX8MP based phyCORE-i.MX8MP
> > and phyBOARD-Pollux RDK.
> > 
> > Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> > b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 934289446abb..880d93092f37 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -433,6 +433,13 @@ properties:
> >                - fsl,imx8mp-evk            # i.MX8MP EVK Board
> >            - const: fsl,imx8mp
> >  
> > +      - description: PHYTEC phyCORE-i.MX8MP SoM based boards
> > +        items:
> > +          - enum:
> > +              - phytec,imx8mp-phycore-som         # phyCORE-
> > i.MX8MP SoM
> > +              - phytec,imx8mp-phyboard-pollux-rdk # phyBOARD-
> > Pollux RDK
> 
> These do not look correct. In this way, you should include them in
> "i.MX8MP based Boards" entry. Probably you wanted all "const"
> instead.

I will change them to "const" in v2. 

Thank you,
Teresa

> 
> Best regards,
> Krzysztof
> 
> 
> > +          - const: fsl,imx8mp
> > +
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 934289446abb..880d93092f37 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -433,6 +433,13 @@  properties:
               - fsl,imx8mp-evk            # i.MX8MP EVK Board
           - const: fsl,imx8mp
 
+      - description: PHYTEC phyCORE-i.MX8MP SoM based boards
+        items:
+          - enum:
+              - phytec,imx8mp-phycore-som         # phyCORE-i.MX8MP SoM
+              - phytec,imx8mp-phyboard-pollux-rdk # phyBOARD-Pollux RDK
+          - const: fsl,imx8mp
+
       - description: i.MX8MQ based Boards
         items:
           - enum: