diff mbox series

Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet

Message ID 20201117004253.27A5A27EFD@localhost (mailing list archive)
State Accepted
Commit cffdd6d90482316e18d686060a4397902ea04bd2
Headers show
Series Input: goodix - Add upside-down quirk for Teclast X98 Pro tablet | expand

Commit Message

Simon Beginn Nov. 17, 2020, 12:42 a.m. UTC 
The touchscreen on the Teclast x98 Pro is also mounted upside-down in relation to the display orientation. I added it also to the list of those devices. Verified it works on my device - this has not been tested with more users than myself...

Comments

Bastien Nocera Nov. 17, 2020, 3:05 p.m. UTC | #1 
On Mon, 2020-11-16 at 19:42 -0500, Simon Beginn wrote:
> The touchscreen on the Teclast x98 Pro is also mounted upside-down in
> relation to the display orientation. I added it also to the list of
> those devices. Verified it works on my device - this has not been
> tested with more users than myself...

Looks good to me, thanks.

Signed-off-by: Bastien Nocera <hadess@hadess.net>

> 
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index f8dd416c89b2..7668174b62ed 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -136,6 +136,16 @@ static const struct dmi_system_id
> rotated_screen[] = {
>                         DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
>                 },
>         },
> +       {
> +               .ident = "Teclast X98 Pro",
> +               .matches = {
> +                       /* Only match bios date, because the
> manufacturers bios
> +                        * does not report the board name at all
> (sometimes)...
> +                        */
> +                       DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
> +                       DMI_MATCH(DMI_BIOS_DATE, "10/28/2015"),
> +               },
> +       },
>         {
>                 .ident = "WinBook TW100",
>                 .matches = {
Bastien Nocera Dec. 7, 2020, 3:13 p.m. UTC | #2 
On Tue, 2020-11-17 at 16:05 +0100, Bastien Nocera wrote:
> On Mon, 2020-11-16 at 19:42 -0500, Simon Beginn wrote:
> > The touchscreen on the Teclast x98 Pro is also mounted upside-down
> > in
> > relation to the display orientation. I added it also to the list of
> > those devices. Verified it works on my device - this has not been
> > tested with more users than myself...
> 
> Looks good to me, thanks.
> 
> Signed-off-by: Bastien Nocera <hadess@hadess.net>

Dmitry, this seems to have slipped through the cracks. Can you please
pick it up for the next merge window?

Cheers
Dmitry Torokhov Dec. 8, 2020, 1:53 a.m. UTC | #3 
Hi Bastien,

On Mon, Dec 07, 2020 at 04:13:06PM +0100, Bastien Nocera wrote:
> On Tue, 2020-11-17 at 16:05 +0100, Bastien Nocera wrote:
> > On Mon, 2020-11-16 at 19:42 -0500, Simon Beginn wrote:
> > > The touchscreen on the Teclast x98 Pro is also mounted upside-down
> > > in
> > > relation to the display orientation. I added it also to the list of
> > > those devices. Verified it works on my device - this has not been
> > > tested with more users than myself...
> > 
> > Looks good to me, thanks.
> > 
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> 
> Dmitry, this seems to have slipped through the cracks. Can you please
> pick it up for the next merge window?

Argh, the original patch went into spam folder because the domain
requires dmarc enforcement and Gmail is happy to oblige:

ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-input-owner@vger.kernel.org
       designates 23.128.96.18 as permitted sender)
       smtp.mailfrom=linux-input-owner@vger.kernel.org;
              dmarc=fail (p=REJECT sp=REJECT dis=QUARANTINE)
	      header.from=simonmicro.de

Regardless, I need "Signed-off-by" from Simon before I can apply it.

Thanks.
Dmitry Torokhov Dec. 11, 2020, 10:36 p.m. UTC | #4 
Hi Simon,

On Fri, Dec 11, 2020 at 11:08:58PM +0100, Simon Beginn wrote:
> Hi,
> 
> all right - try #3
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Simon Beginn <linux@simonmicro.de>

Could you please send your Signed-off-by _with the patch_ so that I do
not have try to reassemble this from separate emails. Also, I see that
in the original patch either your editor or mailer converted all tabs
into spaces so that the patch does not apply.

Thanks.
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index f8dd416c89b2..7668174b62ed 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -136,6 +136,16 @@  static const struct dmi_system_id rotated_screen[] = {
                        DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
                },
        },
+       {
+               .ident = "Teclast X98 Pro",
+               .matches = {
+                       /* Only match bios date, because the manufacturers bios
+                        * does not report the board name at all (sometimes)...
+                        */
+                       DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
+                       DMI_MATCH(DMI_BIOS_DATE, "10/28/2015"),
+               },
+       },
        {
                .ident = "WinBook TW100",
                .matches = {