| Message ID | 1607303055-5199-1-git-send-email-tiantao6@hisilicon.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/drv: switch to using devm_add_action_or_reset() | expand |
Am 07.12.20 um 02:04 schrieb Tian Tao: > switch to using devm_add_action_or_reset() instead of devm_add_action. > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> I'm surprised that devm_drm_dev_init() didn't already use devm_add_action_or_reset(). But it doesn't look special, so Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/gpu/drm/drm_drv.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c > index 7343038..b92f7fd 100644 > --- a/drivers/gpu/drm/drm_drv.c > +++ b/drivers/gpu/drm/drm_drv.c > @@ -675,11 +675,8 @@ static int devm_drm_dev_init(struct device *parent, > if (ret) > return ret; > > - ret = devm_add_action(parent, devm_drm_dev_init_release, dev); > - if (ret) > - devm_drm_dev_init_release(dev); > - > - return ret; > + return devm_add_action_or_reset(parent, > + devm_drm_dev_init_release, dev); > } > > void *__devm_drm_dev_alloc(struct device *parent, >
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 7343038..b92f7fd 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -675,11 +675,8 @@ static int devm_drm_dev_init(struct device *parent, if (ret) return ret; - ret = devm_add_action(parent, devm_drm_dev_init_release, dev); - if (ret) - devm_drm_dev_init_release(dev); - - return ret; + return devm_add_action_or_reset(parent, + devm_drm_dev_init_release, dev); } void *__devm_drm_dev_alloc(struct device *parent,
switch to using devm_add_action_or_reset() instead of devm_add_action. Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- drivers/gpu/drm/drm_drv.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)