| Message ID | 20201204030953.837-1-yuzenghui@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pcie_aer: Fix help message of pcie_aer_inject_error command | expand |
* Zenghui Yu (yuzenghui@huawei.com) wrote: > There is an interesting typo in the help message of pcie_aer_inject_error > command. Use 'tlp' instead of 'tlb' to match the PCIe AER term. > > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> Well spotted; thanks! Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > hmp-commands.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index ff2d7aa8f3..dd460eb908 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1302,8 +1302,8 @@ ERST > " -c for correctable error\n\t\t\t" > "<id> = qdev device id\n\t\t\t" > "<error_status> = error string or 32bit\n\t\t\t" > - "<tlb header> = 32bit x 4\n\t\t\t" > - "<tlb header prefix> = 32bit x 4", > + "<tlp header> = 32bit x 4\n\t\t\t" > + "<tlp header prefix> = 32bit x 4", > .cmd = hmp_pcie_aer_inject_error, > }, > > -- > 2.19.1 >
* Zenghui Yu (yuzenghui@huawei.com) wrote: > There is an interesting typo in the help message of pcie_aer_inject_error > command. Use 'tlp' instead of 'tlb' to match the PCIe AER term. > > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> Queued > --- > hmp-commands.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index ff2d7aa8f3..dd460eb908 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1302,8 +1302,8 @@ ERST > " -c for correctable error\n\t\t\t" > "<id> = qdev device id\n\t\t\t" > "<error_status> = error string or 32bit\n\t\t\t" > - "<tlb header> = 32bit x 4\n\t\t\t" > - "<tlb header prefix> = 32bit x 4", > + "<tlp header> = 32bit x 4\n\t\t\t" > + "<tlp header prefix> = 32bit x 4", > .cmd = hmp_pcie_aer_inject_error, > }, > > -- > 2.19.1 > >
On Tue, Dec 08, 2020 at 06:37:53PM +0000, Dr. David Alan Gilbert wrote: > * Zenghui Yu (yuzenghui@huawei.com) wrote: > > There is an interesting typo in the help message of pcie_aer_inject_error > > command. Use 'tlp' instead of 'tlb' to match the PCIe AER term. > > > > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> > > Queued Oh I just queued it too ;) should not be a problem ... > > --- > > hmp-commands.hx | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hmp-commands.hx b/hmp-commands.hx > > index ff2d7aa8f3..dd460eb908 100644 > > --- a/hmp-commands.hx > > +++ b/hmp-commands.hx > > @@ -1302,8 +1302,8 @@ ERST > > " -c for correctable error\n\t\t\t" > > "<id> = qdev device id\n\t\t\t" > > "<error_status> = error string or 32bit\n\t\t\t" > > - "<tlb header> = 32bit x 4\n\t\t\t" > > - "<tlb header prefix> = 32bit x 4", > > + "<tlp header> = 32bit x 4\n\t\t\t" > > + "<tlp header prefix> = 32bit x 4", > > .cmd = hmp_pcie_aer_inject_error, > > }, > > > > -- > > 2.19.1 > > > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/hmp-commands.hx b/hmp-commands.hx index ff2d7aa8f3..dd460eb908 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1302,8 +1302,8 @@ ERST " -c for correctable error\n\t\t\t" "<id> = qdev device id\n\t\t\t" "<error_status> = error string or 32bit\n\t\t\t" - "<tlb header> = 32bit x 4\n\t\t\t" - "<tlb header prefix> = 32bit x 4", + "<tlp header> = 32bit x 4\n\t\t\t" + "<tlp header prefix> = 32bit x 4", .cmd = hmp_pcie_aer_inject_error, },
There is an interesting typo in the help message of pcie_aer_inject_error command. Use 'tlp' instead of 'tlb' to match the PCIe AER term. Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> --- hmp-commands.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)