diff mbox series

[v4,2/5] dt-bindings: arm: fsl: add Kverneland UT1, UT1Q and UI1P boards

Message ID 20201201072449.28600-3-o.rempel@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series mainline Kverneland boards | expand

Commit Message

Oleksij Rempel Dec. 1, 2020, 7:24 a.m. UTC
Add Kverneland UT1 (imx6dl), UT1Q (imx6q) and UT1P (imx6dp) based boards

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring (Arm) Dec. 9, 2020, 3:43 p.m. UTC | #1
On Tue, Dec 01, 2020 at 08:24:45AM +0100, Oleksij Rempel wrote:
> Add Kverneland UT1 (imx6dl), UT1Q (imx6q) and UT1P (imx6dp) based boards
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 490cbc75b18a..7b2f83bb56cb 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -210,6 +210,7 @@ properties:
>                - kiebackpeter,imx6q-tpc    # K+P i.MX6 Quad TPC Board
>                - kontron,imx6q-samx6i      # Kontron i.MX6 Dual/Quad SMARC Module
>                - kosagi,imx6q-novena       # Kosagi Novena Dual/Quad
> +              - kvg,vicut1q               # Kverneland UT1Q board
>                - logicpd,imx6q-logicpd
>                - lwn,display5              # Liebherr Display5 i.MX6 Quad Board
>                - lwn,mccmon6               # Liebherr Monitor6 i.MX6 Quad Board
> @@ -331,6 +332,7 @@ properties:
>                - fsl,imx6qp-sabreauto      # i.MX6 Quad Plus SABRE Automotive Board
>                - fsl,imx6qp-sabresd        # i.MX6 Quad Plus SABRE Smart Device Board
>                - karo,imx6qp-tx6qp         # Ka-Ro electronics TX6QP-8037 Module
> +              - kvg,vicutp                # Kverneland UT1P board

Should be kvg,vicut1p?

>                - prt,prtwd3                # Protonic WD3 board
>                - wand,imx6qp-wandboard     # Wandboard i.MX6 QuadPlus Board
>                - zii,imx6qp-zii-rdu2       # ZII RDU2+ Board
> @@ -364,6 +366,7 @@ properties:
>                - fsl,imx6dl-sabresd        # i.MX6 DualLite SABRE Smart Device Board
>                - karo,imx6dl-tx6dl         # Ka-Ro electronics TX6U Modules
>                - kontron,imx6dl-samx6i     # Kontron i.MX6 Solo SMARC Module
> +              - kvg,vicut1                # Kverneland UT1 board
>                - ply,plybas                # Plymovent BAS board
>                - ply,plym2m                # Plymovent M2M board
>                - poslab,imx6dl-savageboard # Poslab SavageBoard Dual
> -- 
> 2.29.2
>
Oleksij Rempel Dec. 10, 2020, 8:51 a.m. UTC | #2
On Wed, Dec 09, 2020 at 09:43:08AM -0600, Rob Herring wrote:
> On Tue, Dec 01, 2020 at 08:24:45AM +0100, Oleksij Rempel wrote:
> > Add Kverneland UT1 (imx6dl), UT1Q (imx6q) and UT1P (imx6dp) based boards
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 490cbc75b18a..7b2f83bb56cb 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -210,6 +210,7 @@ properties:
> >                - kiebackpeter,imx6q-tpc    # K+P i.MX6 Quad TPC Board
> >                - kontron,imx6q-samx6i      # Kontron i.MX6 Dual/Quad SMARC Module
> >                - kosagi,imx6q-novena       # Kosagi Novena Dual/Quad
> > +              - kvg,vicut1q               # Kverneland UT1Q board
> >                - logicpd,imx6q-logicpd
> >                - lwn,display5              # Liebherr Display5 i.MX6 Quad Board
> >                - lwn,mccmon6               # Liebherr Monitor6 i.MX6 Quad Board
> > @@ -331,6 +332,7 @@ properties:
> >                - fsl,imx6qp-sabreauto      # i.MX6 Quad Plus SABRE Automotive Board
> >                - fsl,imx6qp-sabresd        # i.MX6 Quad Plus SABRE Smart Device Board
> >                - karo,imx6qp-tx6qp         # Ka-Ro electronics TX6QP-8037 Module
> > +              - kvg,vicutp                # Kverneland UT1P board
> 
> Should be kvg,vicut1p?

No. At least it is consequent with boot loader and existing products.

> >                - prt,prtwd3                # Protonic WD3 board
> >                - wand,imx6qp-wandboard     # Wandboard i.MX6 QuadPlus Board
> >                - zii,imx6qp-zii-rdu2       # ZII RDU2+ Board
> > @@ -364,6 +366,7 @@ properties:
> >                - fsl,imx6dl-sabresd        # i.MX6 DualLite SABRE Smart Device Board
> >                - karo,imx6dl-tx6dl         # Ka-Ro electronics TX6U Modules
> >                - kontron,imx6dl-samx6i     # Kontron i.MX6 Solo SMARC Module
> > +              - kvg,vicut1                # Kverneland UT1 board
> >                - ply,plybas                # Plymovent BAS board
> >                - ply,plym2m                # Plymovent M2M board
> >                - poslab,imx6dl-savageboard # Poslab SavageBoard Dual
> > -- 
> > 2.29.2
> > 

Regards,
Oleksij
Rob Herring (Arm) Dec. 11, 2020, 3:08 a.m. UTC | #3
On Tue, 01 Dec 2020 08:24:45 +0100, Oleksij Rempel wrote:
> Add Kverneland UT1 (imx6dl), UT1Q (imx6q) and UT1P (imx6dp) based boards
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 490cbc75b18a..7b2f83bb56cb 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -210,6 +210,7 @@  properties:
               - kiebackpeter,imx6q-tpc    # K+P i.MX6 Quad TPC Board
               - kontron,imx6q-samx6i      # Kontron i.MX6 Dual/Quad SMARC Module
               - kosagi,imx6q-novena       # Kosagi Novena Dual/Quad
+              - kvg,vicut1q               # Kverneland UT1Q board
               - logicpd,imx6q-logicpd
               - lwn,display5              # Liebherr Display5 i.MX6 Quad Board
               - lwn,mccmon6               # Liebherr Monitor6 i.MX6 Quad Board
@@ -331,6 +332,7 @@  properties:
               - fsl,imx6qp-sabreauto      # i.MX6 Quad Plus SABRE Automotive Board
               - fsl,imx6qp-sabresd        # i.MX6 Quad Plus SABRE Smart Device Board
               - karo,imx6qp-tx6qp         # Ka-Ro electronics TX6QP-8037 Module
+              - kvg,vicutp                # Kverneland UT1P board
               - prt,prtwd3                # Protonic WD3 board
               - wand,imx6qp-wandboard     # Wandboard i.MX6 QuadPlus Board
               - zii,imx6qp-zii-rdu2       # ZII RDU2+ Board
@@ -364,6 +366,7 @@  properties:
               - fsl,imx6dl-sabresd        # i.MX6 DualLite SABRE Smart Device Board
               - karo,imx6dl-tx6dl         # Ka-Ro electronics TX6U Modules
               - kontron,imx6dl-samx6i     # Kontron i.MX6 Solo SMARC Module
+              - kvg,vicut1                # Kverneland UT1 board
               - ply,plybas                # Plymovent BAS board
               - ply,plym2m                # Plymovent M2M board
               - poslab,imx6dl-savageboard # Poslab SavageBoard Dual