| Message ID | 20201210194044.255887860@linutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | genirq: Treewide hunt for irq descriptor abuse and assorted fixes | expand |
On 2020-12-10 12:25 p.m., Thomas Gleixner wrote: > Use the proper core function. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Jon Mason <jdmason@kudzu.us> > Cc: Dave Jiang <dave.jiang@intel.com> > Cc: Allen Hubbe <allenbh@gmail.com> > Cc: linux-ntb@googlegroups.com Looks good to me. Reviewed-by: Logan Gunthorpe <logang@deltatee.com> > --- > drivers/ntb/msi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > --- a/drivers/ntb/msi.c > +++ b/drivers/ntb/msi.c > @@ -282,15 +282,13 @@ int ntbm_msi_request_threaded_irq(struct > struct ntb_msi_desc *msi_desc) > { > struct msi_desc *entry; > - struct irq_desc *desc; > int ret; > > if (!ntb->msi) > return -EINVAL; > > for_each_pci_msi_entry(entry, ntb->pdev) { > - desc = irq_to_desc(entry->irq); > - if (desc->action) > + if (irq_has_action(entry->irq)) > continue; > > ret = devm_request_threaded_irq(&ntb->dev, entry->irq, handler, >
--- a/drivers/ntb/msi.c +++ b/drivers/ntb/msi.c @@ -282,15 +282,13 @@ int ntbm_msi_request_threaded_irq(struct struct ntb_msi_desc *msi_desc) { struct msi_desc *entry; - struct irq_desc *desc; int ret; if (!ntb->msi) return -EINVAL; for_each_pci_msi_entry(entry, ntb->pdev) { - desc = irq_to_desc(entry->irq); - if (desc->action) + if (irq_has_action(entry->irq)) continue; ret = devm_request_threaded_irq(&ntb->dev, entry->irq, handler,
Use the proper core function. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Jon Mason <jdmason@kudzu.us> Cc: Dave Jiang <dave.jiang@intel.com> Cc: Allen Hubbe <allenbh@gmail.com> Cc: linux-ntb@googlegroups.com --- drivers/ntb/msi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)