| Message ID | 20201210211653.879044-1-pmalani@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ecf4d4310a16c32fee081924a1aebe9f4c7c0403 |
| Headers | show |
| Series | [v2] usb: typec: Add class for plug alt mode device | expand |
Hi Prashant, On Thu, Dec 10, 2020 at 01:16:54PM -0800, Prashant Malani wrote: > Add the Type C class for plug alternate mode devices which are being > registered by the Type C connector class. This ensures that udev events > get generated when the plug alt modes are registered. > > Signed-off-by: Prashant Malani <pmalani@chromium.org> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> Reviewed-by: Benson Leung <bleung@chromium.org> > --- > > Changes in v2: > - Changed code to set the class member instead of bus. > - Removed the alteration to typec_bus.rst since it's not longer > required. > - Updated the commit message and subject to reflect the change in code. > > v1: https://lore.kernel.org/linux-usb/20201203030846.51669-1-pmalani@chromium.org/ > > drivers/usb/typec/class.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index 35eec707cb51..29d05b45cc9d 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -482,6 +482,10 @@ typec_register_altmode(struct device *parent, > if (is_typec_partner(parent)) > alt->adev.dev.bus = &typec_bus; > > + /* Plug alt modes need a class to generate udev events. */ > + if (is_typec_plug(parent)) > + alt->adev.dev.class = typec_class; > + > ret = device_register(&alt->adev.dev); > if (ret) { > dev_err(parent, "failed to register alternate mode (%d)\n", > -- > 2.29.2.576.ga3fc446d84-goog >
On Thu, Dec 10, 2020 at 01:16:54PM -0800, Prashant Malani wrote: > Add the Type C class for plug alternate mode devices which are being > registered by the Type C connector class. This ensures that udev events > get generated when the plug alt modes are registered. > > Signed-off-by: Prashant Malani <pmalani@chromium.org> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > > Changes in v2: > - Changed code to set the class member instead of bus. > - Removed the alteration to typec_bus.rst since it's not longer > required. > - Updated the commit message and subject to reflect the change in code. > > v1: https://lore.kernel.org/linux-usb/20201203030846.51669-1-pmalani@chromium.org/ > > drivers/usb/typec/class.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index 35eec707cb51..29d05b45cc9d 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -482,6 +482,10 @@ typec_register_altmode(struct device *parent, > if (is_typec_partner(parent)) > alt->adev.dev.bus = &typec_bus; > > + /* Plug alt modes need a class to generate udev events. */ > + if (is_typec_plug(parent)) > + alt->adev.dev.class = typec_class; > + > ret = device_register(&alt->adev.dev); > if (ret) { > dev_err(parent, "failed to register alternate mode (%d)\n", > -- > 2.29.2.576.ga3fc446d84-goog thanks,
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index 35eec707cb51..29d05b45cc9d 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -482,6 +482,10 @@ typec_register_altmode(struct device *parent, if (is_typec_partner(parent)) alt->adev.dev.bus = &typec_bus; + /* Plug alt modes need a class to generate udev events. */ + if (is_typec_plug(parent)) + alt->adev.dev.class = typec_class; + ret = device_register(&alt->adev.dev); if (ret) { dev_err(parent, "failed to register alternate mode (%d)\n",
Add the Type C class for plug alternate mode devices which are being registered by the Type C connector class. This ensures that udev events get generated when the plug alt modes are registered. Signed-off-by: Prashant Malani <pmalani@chromium.org> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> --- Changes in v2: - Changed code to set the class member instead of bus. - Removed the alteration to typec_bus.rst since it's not longer required. - Updated the commit message and subject to reflect the change in code. v1: https://lore.kernel.org/linux-usb/20201203030846.51669-1-pmalani@chromium.org/ drivers/usb/typec/class.c | 4 ++++ 1 file changed, 4 insertions(+)