| Message ID | 20201210160521.3417426-6-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | USB: typec: various patches | expand |
On Thu, Dec 10, 2020 at 05:05:21PM +0100, Greg Kroah-Hartman wrote: > From: Badhri Jagan Sridharan <badhri@google.com> > > "Table 4-19. POWER_CONTROL Register Definition" from tcpci spec > defines BIT(3) as the control bit for bleed discharge. > > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Cc: Kyle Tso <kyletso@google.com> > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> > Signed-off-by: Will McVicker <willmcvicker@google.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Just wondering - is that going to be used in a follow-up commit ? Reviewed-by: Guenter Roeck <linux@roeck-us.net> Guenter > --- > drivers/usb/typec/tcpm/tcpci.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/tcpm/tcpci.h b/drivers/usb/typec/tcpm/tcpci.h > index 116a69c85e38..c3c7d07d9b4e 100644 > --- a/drivers/usb/typec/tcpm/tcpci.h > +++ b/drivers/usb/typec/tcpm/tcpci.h > @@ -72,6 +72,7 @@ > > #define TCPC_POWER_CTRL 0x1c > #define TCPC_POWER_CTRL_VCONN_ENABLE BIT(0) > +#define TCPC_POWER_CTRL_BLEED_DISCHARGE BIT(3) > #define TCPC_POWER_CTRL_AUTO_DISCHARGE BIT(4) > #define TCPC_FAST_ROLE_SWAP_EN BIT(7) > > -- > 2.29.2 >
Hi Guenter, Yes I will send a follow up patch to update tcpci_maxim.c. Thanks, Badhri On Thu, Dec 10, 2020 at 9:45 AM Guenter Roeck <linux@roeck-us.net> wrote: > > On Thu, Dec 10, 2020 at 05:05:21PM +0100, Greg Kroah-Hartman wrote: > > From: Badhri Jagan Sridharan <badhri@google.com> > > > > "Table 4-19. POWER_CONTROL Register Definition" from tcpci spec > > defines BIT(3) as the control bit for bleed discharge. > > > > Cc: Guenter Roeck <linux@roeck-us.net> > > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > Cc: Kyle Tso <kyletso@google.com> > > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> > > Signed-off-by: Will McVicker <willmcvicker@google.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Just wondering - is that going to be used in a follow-up commit ? > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > Guenter > > > --- > > drivers/usb/typec/tcpm/tcpci.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/typec/tcpm/tcpci.h b/drivers/usb/typec/tcpm/tcpci.h > > index 116a69c85e38..c3c7d07d9b4e 100644 > > --- a/drivers/usb/typec/tcpm/tcpci.h > > +++ b/drivers/usb/typec/tcpm/tcpci.h > > @@ -72,6 +72,7 @@ > > > > #define TCPC_POWER_CTRL 0x1c > > #define TCPC_POWER_CTRL_VCONN_ENABLE BIT(0) > > +#define TCPC_POWER_CTRL_BLEED_DISCHARGE BIT(3) > > #define TCPC_POWER_CTRL_AUTO_DISCHARGE BIT(4) > > #define TCPC_FAST_ROLE_SWAP_EN BIT(7) > > > > -- > > 2.29.2 > >
Hi Greg, I have a patch ready to enable BLEED_DISCHARGE in tcpci code. I will send that in once you merge this patch to usb-next. Thanks, Badhri On Thu, Dec 10, 2020 at 10:56 AM Badhri Jagan Sridharan <badhri@google.com> wrote: > > Hi Guenter, > > Yes I will send a follow up patch to update tcpci_maxim.c. > > Thanks, > Badhri > > > On Thu, Dec 10, 2020 at 9:45 AM Guenter Roeck <linux@roeck-us.net> wrote: > > > > On Thu, Dec 10, 2020 at 05:05:21PM +0100, Greg Kroah-Hartman wrote: > > > From: Badhri Jagan Sridharan <badhri@google.com> > > > > > > "Table 4-19. POWER_CONTROL Register Definition" from tcpci spec > > > defines BIT(3) as the control bit for bleed discharge. > > > > > > Cc: Guenter Roeck <linux@roeck-us.net> > > > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > > Cc: Kyle Tso <kyletso@google.com> > > > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> > > > Signed-off-by: Will McVicker <willmcvicker@google.com> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > Just wondering - is that going to be used in a follow-up commit ? > > > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > > > Guenter > > > > > --- > > > drivers/usb/typec/tcpm/tcpci.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/usb/typec/tcpm/tcpci.h b/drivers/usb/typec/tcpm/tcpci.h > > > index 116a69c85e38..c3c7d07d9b4e 100644 > > > --- a/drivers/usb/typec/tcpm/tcpci.h > > > +++ b/drivers/usb/typec/tcpm/tcpci.h > > > @@ -72,6 +72,7 @@ > > > > > > #define TCPC_POWER_CTRL 0x1c > > > #define TCPC_POWER_CTRL_VCONN_ENABLE BIT(0) > > > +#define TCPC_POWER_CTRL_BLEED_DISCHARGE BIT(3) > > > #define TCPC_POWER_CTRL_AUTO_DISCHARGE BIT(4) > > > #define TCPC_FAST_ROLE_SWAP_EN BIT(7) > > > > > > -- > > > 2.29.2 > > >
On Thu, Dec 10, 2020 at 08:47:04PM -0800, Badhri Jagan Sridharan wrote: > Hi Greg, > > I have a patch ready to enable BLEED_DISCHARGE in tcpci code. > I will send that in once you merge this patch to usb-next. Feel free to send that now, no need to wait :) thanks, greg k-h
diff --git a/drivers/usb/typec/tcpm/tcpci.h b/drivers/usb/typec/tcpm/tcpci.h index 116a69c85e38..c3c7d07d9b4e 100644 --- a/drivers/usb/typec/tcpm/tcpci.h +++ b/drivers/usb/typec/tcpm/tcpci.h @@ -72,6 +72,7 @@ #define TCPC_POWER_CTRL 0x1c #define TCPC_POWER_CTRL_VCONN_ENABLE BIT(0) +#define TCPC_POWER_CTRL_BLEED_DISCHARGE BIT(3) #define TCPC_POWER_CTRL_AUTO_DISCHARGE BIT(4) #define TCPC_FAST_ROLE_SWAP_EN BIT(7)