| Message ID | 20201102120614.11109-1-lokeshvutla@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | irqchip/ti-sci-inta: Fix printing of inta id on probe success | expand |
Hi Marc, On 02/11/20 5:36 pm, Lokesh Vutla wrote: > On a successful probe, the driver tries to print a success message with > INTA device id. It uses pdev->id for printing the id but id is stored in > inta->ti_sci_id. Fix it by correcting the dev_info parameter. > > Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC") > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> Gentle ping . Thanks and regards, Lokesh > --- > drivers/irqchip/irq-ti-sci-inta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c > index e0cceb81c648..d2a2a98c23c2 100644 > --- a/drivers/irqchip/irq-ti-sci-inta.c > +++ b/drivers/irqchip/irq-ti-sci-inta.c > @@ -649,7 +649,7 @@ static int ti_sci_inta_irq_domain_probe(struct platform_device *pdev) > INIT_LIST_HEAD(&inta->vint_list); > mutex_init(&inta->vint_mutex); > > - dev_info(dev, "Interrupt Aggregator domain %d created\n", pdev->id); > + dev_info(dev, "Interrupt Aggregator domain %d created\n", inta->ti_sci_id); > > return 0; > } >
On Mon, 2 Nov 2020 17:36:14 +0530, Lokesh Vutla wrote: > On a successful probe, the driver tries to print a success message with > INTA device id. It uses pdev->id for printing the id but id is stored in > inta->ti_sci_id. Fix it by correcting the dev_info parameter. Applied to irq/irqchip-next, thanks! [1/1] irqchip/ti-sci-inta: Fix printing of inta id on probe success commit: b10d5fd489b0c67f59cbdd28d95f4bd9f76a62f2 Cheers, M.
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c index e0cceb81c648..d2a2a98c23c2 100644 --- a/drivers/irqchip/irq-ti-sci-inta.c +++ b/drivers/irqchip/irq-ti-sci-inta.c @@ -649,7 +649,7 @@ static int ti_sci_inta_irq_domain_probe(struct platform_device *pdev) INIT_LIST_HEAD(&inta->vint_list); mutex_init(&inta->vint_mutex); - dev_info(dev, "Interrupt Aggregator domain %d created\n", pdev->id); + dev_info(dev, "Interrupt Aggregator domain %d created\n", inta->ti_sci_id); return 0; }
On a successful probe, the driver tries to print a success message with INTA device id. It uses pdev->id for printing the id but id is stored in inta->ti_sci_id. Fix it by correcting the dev_info parameter. Fixes: 5c4b585d2910 ("irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC") Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- drivers/irqchip/irq-ti-sci-inta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)