[v15,0/4] Add Versal usb model

Message

Sai Pavan Boddu Dec. 3, 2020, 7:22 p.m. UTC

This patch series adds dwc3 usb controller to versal SOC.

Changes for V2:
    Make XHCIState non-qom
    Use container_of functions for retriving pci device instance
    Initialize the AddressSpace pointer in PATCH 1/3 itself Changes for V3:
    Convert XHCIState to TYPE_DEVICE and register as a child of XHCIPciState.
Changes for V4:
    Add DWC3 usb controller
    Add versal, usb2-reg module
    Connect sysbus xhci to versal virt board Changes for V5:
    Add extra info about dwc3 and usb2_regs devices in commit messages
    Use only one irq for versal usb controller
    Mark the unimplemented registers in dwc3 controller
    Rebase the patches over master.
    Move few mispalced contents from patch 2/7 to 3/7.
    Fix the author names in the header.
    Move the inclusion of "sysemu/dma.h" from patch 1/7 to 3/7 Changes for V6:
    Fixed style issue in patch 7/7
    Renamed usb2_reg model to VersalUsb2CtrlReg
    Fixed author in headers
Changes for V7:
    Create a usb structure to keep things clean
    Remove the repeated patch in the series i.e 5/7 Changes for V8:
    Fix vmstate sturcts to support cross version migration.
Changes for V9:
    Added recommended changes to fix vmstate migration.
    Fixed commit message on 3/7.
Changes for V10:
    use vmstate_post_load avaialble in VMStateDescription
    tested vmstate cross migration.
Changes for V11:
    Removed the patches which got accepted
    Changed object name "USB2Reg" -> "ctrl"
    Updated Subject line on cover letter.
Changes for V12:
    Use reset class for usb2-ctrl-regs module
    Move the few register update to realize
    Marked registers which are unimplemented in regapi model
Changs for V13:
    Add usb subsystem for xilinx devices,
    Memory Map xhci internally to dwc3 device,
    Add respective changes to connect VersalUsb2 subsystem to xilinx-versal.
Changes for V14:
    Fix "make check" failures, by specifing right dependencies in Kconfig for
    usb_dwc3 device.
Changes for V15:
    Fixed commit message in Patch 4/4, and addressed code style issues.
    In VersalDWC3 model added vmstate struct.

Sai Pavan Boddu (2):
  usb: Add versal-usb2-ctrl-regs module
  usb: xlnx-usb-subsystem: Add xilinx usb subsystem

Vikram Garhwal (2):
  usb: Add DWC3 model
  arm: xlnx-versal: Connect usb to virt-versal

 hw/arm/xlnx-versal-virt.c                   |  55 +++
 hw/arm/xlnx-versal.c                        |  26 ++
 hw/usb/Kconfig                              |  10 +
 hw/usb/hcd-dwc3.c                           | 689 ++++++++++++++++++++++++++++
 hw/usb/meson.build                          |   3 +
 hw/usb/xlnx-usb-subsystem.c                 |  94 ++++
 hw/usb/xlnx-versal-usb2-ctrl-regs.c         | 229 +++++++++
 include/hw/arm/xlnx-versal.h                |   9 +
 include/hw/usb/hcd-dwc3.h                   |  55 +++
 include/hw/usb/xlnx-usb-subsystem.h         |  45 ++
 include/hw/usb/xlnx-versal-usb2-ctrl-regs.h |  45 ++
 11 files changed, 1260 insertions(+)
 create mode 100644 hw/usb/hcd-dwc3.c
 create mode 100644 hw/usb/xlnx-usb-subsystem.c
 create mode 100644 hw/usb/xlnx-versal-usb2-ctrl-regs.c
 create mode 100644 include/hw/usb/hcd-dwc3.h
 create mode 100644 include/hw/usb/xlnx-usb-subsystem.h
 create mode 100644 include/hw/usb/xlnx-versal-usb2-ctrl-regs.h

Comments

Peter Maydell Dec. 11, 2020, 4:09 p.m. UTC | #1

On Thu, 3 Dec 2020 at 19:18, Sai Pavan Boddu <[e-mail]> wrote:
>
> This patch series adds dwc3 usb controller to versal SOC.
>



Applied to target-arm.next, thanks.

-- PMM

Sai Pavan Boddu Dec. 11, 2020, 6:17 p.m. UTC | #2

Hi,

Finally, usb series got accepted. I thank Vikram and Edgar for the great support.

Regards,
Sai Pavan

-----Original Message-----
From: Peter Maydell <[e-mail]> 
Sent: Friday, December 11, 2020 9:40 PM
To: Sai Pavan Boddu <[e-mail]>
Cc: Markus Armbruster <[e-mail]>; Marc-André Lureau <[e-mail]>; Paolo Bonzini <[e-mail]>; Gerd Hoffmann <[e-mail]>; Edgar Iglesias <[e-mail]>; Francisco Eduardo Iglesias <[e-mail]>; Alistair Francis <[e-mail]>; Eduardo Habkost <[e-mail]>; Ying Fang <[e-mail]>; Philippe Mathieu-Daudé <[e-mail]>; Vikram Garhwal <[e-mail]>; Paul Zimmerman <[e-mail]>; Sai Pavan Boddu <[e-mail]>; QEMU Developers <[e-mail]>
Subject: Re: [PATCH v15 0/4] Add Versal usb model

On Thu, 3 Dec 2020 at 19:18, Sai Pavan Boddu <[e-mail]> wrote:
>
> This patch series adds dwc3 usb controller to versal SOC.
>



Applied to target-arm.next, thanks.

-- PMM

Sai Pavan Boddu Dec. 11, 2020, 7:04 p.m. UTC | #3

Hi,

> -----Original Message-----
> From: Peter Maydell <[e-mail]>
> Sent: Friday, December 11, 2020 9:40 PM
> To: Sai Pavan Boddu <[e-mail]>
> Cc: Markus Armbruster <[e-mail]>; Marc-André Lureau
> <[e-mail]>; Paolo Bonzini <[e-mail]>;
> Gerd Hoffmann <[e-mail]>; Edgar Iglesias <[e-mail]>;
> Francisco Eduardo Iglesias <[e-mail]>; Alistair Francis
> <[e-mail]>; Eduardo Habkost <[e-mail]>; Ying
> Fang <[e-mail]>; Philippe Mathieu-Daudé
> <[e-mail]>; Vikram Garhwal <[e-mail]>; Paul Zimmerman
> <[e-mail]>; Sai Pavan Boddu <[e-mail]>; QEMU
> Developers <[e-mail]>
> Subject: Re: [PATCH v15 0/4] Add Versal usb model
> 
> On Thu, 3 Dec 2020 at 19:18, Sai Pavan Boddu <[e-mail]>
> wrote:
> >
> > This patch series adds dwc3 usb controller to versal SOC.
> >
> 
> 
> 
> Applied to target-arm.next, thanks.
Thanks.

Regards,
Sai Pavan
> 
> -- PMM