| Message ID | 20201023061218.2080844-8-kuhn.chenqun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | some memleak trivial patchs | expand |
Le 23/10/2020 à 08:12, Chen Qun a écrit : > From: Pan Nengyuan <pannengyuan@huawei.com> > > local_err is not initialized to NULL, it will cause a assert error as below: > qemu/util/error.c:59: error_setv: Assertion `*errp == NULL' failed. > > Fixes: c6447510690 > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > Reviewed-by: Kevin Wolf <kwolf@redhat.com> > Reviewed-by: Li Qiang <liq3ea@gmail.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > block/file-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/file-posix.c b/block/file-posix.c > index c63926d592..b711124672 100644 > --- a/block/file-posix.c > +++ b/block/file-posix.c > @@ -2110,7 +2110,7 @@ static void raw_aio_attach_aio_context(BlockDriverState *bs, > #endif > #ifdef CONFIG_LINUX_IO_URING > if (s->use_linux_io_uring) { > - Error *local_err; > + Error *local_err = NULL; > if (!aio_setup_linux_io_uring(new_context, &local_err)) { > error_reportf_err(local_err, "Unable to use linux io_uring, " > "falling back to thread pool: "); > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/block/file-posix.c b/block/file-posix.c index c63926d592..b711124672 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2110,7 +2110,7 @@ static void raw_aio_attach_aio_context(BlockDriverState *bs, #endif #ifdef CONFIG_LINUX_IO_URING if (s->use_linux_io_uring) { - Error *local_err; + Error *local_err = NULL; if (!aio_setup_linux_io_uring(new_context, &local_err)) { error_reportf_err(local_err, "Unable to use linux io_uring, " "falling back to thread pool: ");