mbox series

[v3,00/13] Remove GCC < 4.8 checks

Message ID 20201210134752.780923-1-marcandre.lureau@redhat.com (mailing list archive)
Headers show
Series Remove GCC < 4.8 checks | expand

Message

Marc-André Lureau Dec. 10, 2020, 1:47 p.m. UTC 
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

Since commit efc6c07 ("configure: Add a test for the minimum compiler version"),
QEMU explicitely depends on GCC >= 4.8.

v3:
 - drop first patch replacing QEMU_GNUC_PREREQ with G_GNUC_CHECK_VERSION
 - add last patch to remove QEMU_GNUC_PREREQ
 - tweak commit messages to replace clang 3.8 with clang 3.4
 - fix some extra coding style
 - collect r-b/a-b tags

v2:
 - include reviewed Philippe earlier series
 - drop problematic patch to replace GCC_FMT_ATTR, but tweak the check to be clang
 - replace QEMU_GNUC_PREREQ with G_GNUC_CHECK_VERSION
 - split changes
 - add patches to drop __GNUC__ checks (clang advertizes itself as 4.2.1, unless
   -fgnuc-version=0)

Marc-André Lureau (11):
  compiler.h: remove GCC < 3 __builtin_expect fallback
  qemu-plugin.h: remove GCC < 4
  tests: remove GCC < 4 fallbacks
  virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON
  compiler.h: explicit case for Clang printf attribute
  audio: remove GNUC & MSVC check
  poison: remove GNUC check
  xen: remove GNUC check
  compiler: remove GNUC check
  linux-user: remove GNUC check
  compiler.h: remove QEMU_GNUC_PREREQ

Philippe Mathieu-Daudé (2):
  qemu/atomic: Drop special case for unsupported compiler
  accel/tcg: Remove special case for GCC < 4.6

 include/exec/poison.h              |  2 --
 include/hw/xen/interface/io/ring.h |  9 ------
 include/qemu/atomic.h              | 17 -----------
 include/qemu/compiler.h            | 45 ++++++++----------------------
 include/qemu/qemu-plugin.h         |  9 ++----
 scripts/cocci-macro-file.h         |  1 -
 tools/virtiofsd/fuse_common.h      | 11 +-------
 accel/tcg/cpu-exec.c               |  2 +-
 audio/audio.c                      |  8 +-----
 linux-user/strace.c                |  4 ---
 tests/tcg/arm/fcvt.c               |  8 ++----
 11 files changed, 20 insertions(+), 96 deletions(-)

Comments

no-reply@patchew.org Dec. 10, 2020, 1:57 p.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20201210134752.780923-1-marcandre.lureau@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201210134752.780923-1-marcandre.lureau@redhat.com
Subject: [PATCH v3 00/13] Remove GCC < 4.8 checks

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   5e7b204..180834d  master     -> master
 - [tag update]      patchew/20201208055043.31548-1-lersek@redhat.com -> patchew/20201208055043.31548-1-lersek@redhat.com
 - [tag update]      patchew/20201209100811.190316-1-andrey.gruzdev@virtuozzo.com -> patchew/20201209100811.190316-1-andrey.gruzdev@virtuozzo.com
 * [new tag]         patchew/20201210125929.1136390-1-mlevitsk@redhat.com -> patchew/20201210125929.1136390-1-mlevitsk@redhat.com
 * [new tag]         patchew/20201210134752.780923-1-marcandre.lureau@redhat.com -> patchew/20201210134752.780923-1-marcandre.lureau@redhat.com
Switched to a new branch 'test'
778a2e3 compiler.h: remove QEMU_GNUC_PREREQ
0a3f410 linux-user: remove GNUC check
9678c1e compiler: remove GNUC check
a0138f8 xen: remove GNUC check
40f3170 poison: remove GNUC check
b80f5cb audio: remove GNUC & MSVC check
b635f5f compiler.h: explicit case for Clang printf attribute
d52f3c4 virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON
9bbe2a0 tests: remove GCC < 4 fallbacks
7c330cb qemu-plugin.h: remove GCC < 4
434de5d compiler.h: remove GCC < 3 __builtin_expect fallback
0699e78 accel/tcg: Remove special case for GCC < 4.6
03e2318 qemu/atomic: Drop special case for unsupported compiler

=== OUTPUT BEGIN ===
1/13 Checking commit 03e23183fb55 (qemu/atomic: Drop special case for unsupported compiler)
2/13 Checking commit 0699e78a25fb (accel/tcg: Remove special case for GCC < 4.6)
WARNING: architecture specific defines should be avoided
#30: FILE: accel/tcg/cpu-exec.c:727:
+#if defined(__clang__)

total: 0 errors, 1 warnings, 8 lines checked

Patch 2/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/13 Checking commit 434de5d2441a (compiler.h: remove GCC < 3 __builtin_expect fallback)
4/13 Checking commit 7c330cb6e44c (qemu-plugin.h: remove GCC < 4)
5/13 Checking commit 9bbe2a00a228 (tests: remove GCC < 4 fallbacks)
ERROR: space prohibited between function name and open parenthesis '('
#30: FILE: tests/tcg/arm/fcvt.c:76:
+# define SNANF (__builtin_nansf (""))

ERROR: space prohibited between function name and open parenthesis '('
#31: FILE: tests/tcg/arm/fcvt.c:77:
+# define SNAN (__builtin_nans (""))

ERROR: space prohibited between function name and open parenthesis '('
#32: FILE: tests/tcg/arm/fcvt.c:78:
+# define SNANL (__builtin_nansl (""))

total: 3 errors, 0 warnings, 14 lines checked

Patch 5/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/13 Checking commit d52f3c49e7f8 (virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON)
7/13 Checking commit b635f5f0f1c0 (compiler.h: explicit case for Clang printf attribute)
WARNING: architecture specific defines should be avoided
#38: FILE: include/qemu/compiler.h:102:
+#if defined(__clang__)

total: 0 errors, 1 warnings, 30 lines checked

Patch 7/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/13 Checking commit b80f5cb153ae (audio: remove GNUC & MSVC check)
9/13 Checking commit 40f31706c554 (poison: remove GNUC check)
10/13 Checking commit a0138f8b8ca1 (xen: remove GNUC check)
11/13 Checking commit 9678c1e1b0d8 (compiler: remove GNUC check)
12/13 Checking commit 0a3f4102bcfa (linux-user: remove GNUC check)
13/13 Checking commit 778a2e31c5ce (compiler.h: remove QEMU_GNUC_PREREQ)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201210134752.780923-1-marcandre.lureau@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Paolo Bonzini Dec. 14, 2020, 10:20 a.m. UTC | #2 
On 10/12/20 14:47, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Hi,
> 
> Since commit efc6c07 ("configure: Add a test for the minimum compiler version"),
> QEMU explicitely depends on GCC >= 4.8.
> 
> v3:
>   - drop first patch replacing QEMU_GNUC_PREREQ with G_GNUC_CHECK_VERSION
>   - add last patch to remove QEMU_GNUC_PREREQ
>   - tweak commit messages to replace clang 3.8 with clang 3.4
>   - fix some extra coding style
>   - collect r-b/a-b tags
> 
> v2:
>   - include reviewed Philippe earlier series
>   - drop problematic patch to replace GCC_FMT_ATTR, but tweak the check to be clang
>   - replace QEMU_GNUC_PREREQ with G_GNUC_CHECK_VERSION
>   - split changes
>   - add patches to drop __GNUC__ checks (clang advertizes itself as 4.2.1, unless
>     -fgnuc-version=0)
> 
> Marc-André Lureau (11):
>    compiler.h: remove GCC < 3 __builtin_expect fallback
>    qemu-plugin.h: remove GCC < 4
>    tests: remove GCC < 4 fallbacks
>    virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON
>    compiler.h: explicit case for Clang printf attribute
>    audio: remove GNUC & MSVC check
>    poison: remove GNUC check
>    xen: remove GNUC check
>    compiler: remove GNUC check
>    linux-user: remove GNUC check
>    compiler.h: remove QEMU_GNUC_PREREQ
> 
> Philippe Mathieu-Daudé (2):
>    qemu/atomic: Drop special case for unsupported compiler
>    accel/tcg: Remove special case for GCC < 4.6
> 
>   include/exec/poison.h              |  2 --
>   include/hw/xen/interface/io/ring.h |  9 ------
>   include/qemu/atomic.h              | 17 -----------
>   include/qemu/compiler.h            | 45 ++++++++----------------------
>   include/qemu/qemu-plugin.h         |  9 ++----
>   scripts/cocci-macro-file.h         |  1 -
>   tools/virtiofsd/fuse_common.h      | 11 +-------
>   accel/tcg/cpu-exec.c               |  2 +-
>   audio/audio.c                      |  8 +-----
>   linux-user/strace.c                |  4 ---
>   tests/tcg/arm/fcvt.c               |  8 ++----
>   11 files changed, 20 insertions(+), 96 deletions(-)
> 

Queued, thanks.

Paolo