| Message ID | 20201124124538.660710-58-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Convert DSI code to use drm_mipi_dsi and drm_panel | expand |
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:15PM +0200, Tomi Valkeinen wrote: > Add address-cells & size-cells to DSI nodes so that board files do not > need to define them. How about adding ports too, while at it ? It would also be nice to convert the DT bindings to YAML :-) > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: Tony Lindgren <tony@atomide.com> > --- > arch/arm/boot/dts/omap5.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi > index 2bf2e5839a7f..e6f6947965ef 100644 > --- a/arch/arm/boot/dts/omap5.dtsi > +++ b/arch/arm/boot/dts/omap5.dtsi > @@ -517,6 +517,9 @@ dsi1: encoder@0 { > clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>, > <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>; > clock-names = "fck", "sys_clk"; > + > + #address-cells = <1>; > + #size-cells = <0>; > }; > }; > > @@ -549,6 +552,9 @@ dsi2: encoder@0 { > clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>, > <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>; > clock-names = "fck", "sys_clk"; > + > + #address-cells = <1>; > + #size-cells = <0>; > }; > }; >
On 30/11/2020 11:53, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tue, Nov 24, 2020 at 02:45:15PM +0200, Tomi Valkeinen wrote: >> Add address-cells & size-cells to DSI nodes so that board files do not >> need to define them. > > How about adding ports too, while at it ? We don't have ports for other encoders either. I'm not sure if adding ports helps or not, but I think it makes sense to add them consistently to all encoders on all boards if we want to go that way. > It would also be nice to convert the DT bindings to YAML :-) I agree, but not as part of this already 81 patch series. =) Tomi
* Tomi Valkeinen <tomi.valkeinen@ti.com> [201201 10:39]: > On 30/11/2020 11:53, Laurent Pinchart wrote: > > Hi Tomi, > > > > Thank you for the patch. > > > > On Tue, Nov 24, 2020 at 02:45:15PM +0200, Tomi Valkeinen wrote: > >> Add address-cells & size-cells to DSI nodes so that board files do not > >> need to define them. > > > > How about adding ports too, while at it ? > > We don't have ports for other encoders either. I'm not sure if adding ports helps or not, but I > think it makes sense to add them consistently to all encoders on all boards if we want to go that way. > > > It would also be nice to convert the DT bindings to YAML :-) > > I agree, but not as part of this already 81 patch series. =) Please feel free to merge this via the dss tree: Acked-by: Tony Lindgren <tony@atomide.com>
Hi, On Tue, Nov 24, 2020 at 02:45:15PM +0200, Tomi Valkeinen wrote: > Add address-cells & size-cells to DSI nodes so that board files do not > need to define them. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: Tony Lindgren <tony@atomide.com> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > arch/arm/boot/dts/omap5.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi > index 2bf2e5839a7f..e6f6947965ef 100644 > --- a/arch/arm/boot/dts/omap5.dtsi > +++ b/arch/arm/boot/dts/omap5.dtsi > @@ -517,6 +517,9 @@ dsi1: encoder@0 { > clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>, > <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>; > clock-names = "fck", "sys_clk"; > + > + #address-cells = <1>; > + #size-cells = <0>; > }; > }; > > @@ -549,6 +552,9 @@ dsi2: encoder@0 { > clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>, > <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>; > clock-names = "fck", "sys_clk"; > + > + #address-cells = <1>; > + #size-cells = <0>; > }; > }; > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index 2bf2e5839a7f..e6f6947965ef 100644 --- a/arch/arm/boot/dts/omap5.dtsi +++ b/arch/arm/boot/dts/omap5.dtsi @@ -517,6 +517,9 @@ dsi1: encoder@0 { clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>, <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>; clock-names = "fck", "sys_clk"; + + #address-cells = <1>; + #size-cells = <0>; }; }; @@ -549,6 +552,9 @@ dsi2: encoder@0 { clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>, <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>; clock-names = "fck", "sys_clk"; + + #address-cells = <1>; + #size-cells = <0>; }; };
Add address-cells & size-cells to DSI nodes so that board files do not need to define them. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: Tony Lindgren <tony@atomide.com> --- arch/arm/boot/dts/omap5.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)