diff mbox series

xfsdump: don't try to generate .ltdep in inventory/

Message ID 15af018c-caf7-71e7-c353-96775d7173ba@redhat.com (mailing list archive)
State Superseded, archived
Headers show
Series xfsdump: don't try to generate .ltdep in inventory/ | expand

Commit Message

Eric Sandeen Oct. 2, 2020, 7:35 p.m. UTC
.ltdep gets generated from CFILES, and there are none in inventory/
so trying to generate it in that dir leads to a non-fatal error:

Building inventory
    [LTDEP]
gcc: fatal error: no input files
compilation terminated.

inventory/ - like common/ - has files that get linked into other dirs,
and .ltdep is generated there.  So, simply remove the .ltdep generation
from the inventory/ dir.

Reported-by: Thomas Deutschmann <whissi@gentoo.org>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Comments

Bill O'Donnell Dec. 16, 2020, 10:03 p.m. UTC | #1
On Fri, Oct 02, 2020 at 02:35:44PM -0500, Eric Sandeen wrote:
> .ltdep gets generated from CFILES, and there are none in inventory/
> so trying to generate it in that dir leads to a non-fatal error:
> 
> Building inventory
>     [LTDEP]
> gcc: fatal error: no input files
> compilation terminated.
> 
> inventory/ - like common/ - has files that get linked into other dirs,
> and .ltdep is generated there.  So, simply remove the .ltdep generation
> from the inventory/ dir.
> 
> Reported-by: Thomas Deutschmann <whissi@gentoo.org>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

looks fine.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> ---
> 
> diff --git a/inventory/Makefile b/inventory/Makefile
> index cda145e..6624fba 100644
> --- a/inventory/Makefile
> +++ b/inventory/Makefile
> @@ -12,5 +12,3 @@ LSRCFILES = inv_api.c inv_core.c inv_fstab.c inv_idx.c inv_mgr.c \
>  default install install-dev:
>  
>  include $(BUILDRULES)
> -
> --include .ltdep
>
diff mbox series

Patch

diff --git a/inventory/Makefile b/inventory/Makefile
index cda145e..6624fba 100644
--- a/inventory/Makefile
+++ b/inventory/Makefile
@@ -12,5 +12,3 @@  LSRCFILES = inv_api.c inv_core.c inv_fstab.c inv_idx.c inv_mgr.c \
 default install install-dev:
 
 include $(BUILDRULES)
-
--include .ltdep