| Message ID | 20201202125816.168618-1-alexandre.belloni@bootlin.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: at91: sam9x60: remove atmel,osc-bypass support | expand |
On 02.12.2020 14:58, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > The sam9x60 doesn't have the MOSCXTBY bit to enable the crystal oscillator > bypass. > > Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver") > Reported-by: Claudiu Beznea <claudiu.beznea@microchip.com> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > drivers/clk/at91/sam9x60.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c > index 3c4c95603595..c8cbec5308f0 100644 > --- a/drivers/clk/at91/sam9x60.c > +++ b/drivers/clk/at91/sam9x60.c > @@ -174,7 +174,6 @@ static void __init sam9x60_pmc_setup(struct device_node *np) > struct regmap *regmap; > struct clk_hw *hw; > int i; > - bool bypass; > > i = of_property_match_string(np, "clock-names", "td_slck"); > if (i < 0) > @@ -209,10 +208,7 @@ static void __init sam9x60_pmc_setup(struct device_node *np) > if (IS_ERR(hw)) > goto err_free; > > - bypass = of_property_read_bool(np, "atmel,osc-bypass"); > - > - hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name, > - bypass); > + hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name, 0); > if (IS_ERR(hw)) > goto err_free; > main_osc_hw = hw; > -- > 2.28.0 >
Quoting Alexandre Belloni (2020-12-02 04:58:15) > The sam9x60 doesn't have the MOSCXTBY bit to enable the crystal oscillator > bypass. > > Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver") > Reported-by: Claudiu Beznea <claudiu.beznea@microchip.com> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- Applied to clk-next
diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c index 3c4c95603595..c8cbec5308f0 100644 --- a/drivers/clk/at91/sam9x60.c +++ b/drivers/clk/at91/sam9x60.c @@ -174,7 +174,6 @@ static void __init sam9x60_pmc_setup(struct device_node *np) struct regmap *regmap; struct clk_hw *hw; int i; - bool bypass; i = of_property_match_string(np, "clock-names", "td_slck"); if (i < 0) @@ -209,10 +208,7 @@ static void __init sam9x60_pmc_setup(struct device_node *np) if (IS_ERR(hw)) goto err_free; - bypass = of_property_read_bool(np, "atmel,osc-bypass"); - - hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name, - bypass); + hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name, 0); if (IS_ERR(hw)) goto err_free; main_osc_hw = hw;
The sam9x60 doesn't have the MOSCXTBY bit to enable the crystal oscillator bypass. Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver") Reported-by: Claudiu Beznea <claudiu.beznea@microchip.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> --- drivers/clk/at91/sam9x60.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)